Incompatibility with Javascript Aggregator

Viybel - October 30, 2009 - 16:58
Project:Parallel
Version:6.x-1.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:active
Description

The Parallel module sets $scripts src to "//js-subdomain.examples/sites/default/files/js/js_b918e9e12007a05d73f9101cf854afde.js"

On line 94 of javascript_aggregator.module, the regex pattern filters out any path other than base_path() . file_directory_path():

    $path_to_files_directory = base_path() . file_directory_path();
    $pattern = "!(<script type=\"text\/javascript\" src=\"$path_to_files_directory)(.*?)(\"(.*?)><\/script>)!";
    if (preg_match_all($pattern, $scripts, $matches) > 0) {

As a result, any script whose path has been rewritten by Parallel is skipped by JS aggregator.

Vianney Stroebel
Likwid - Spécialistes Drupal - Paris

#1

mikeytown2 - November 9, 2009 - 01:34
Title:Incompatibility with Parallel module» Incompatibility with Javascript Aggregator
Project:Javascript Aggregator» Parallel
Version:6.x-1.x-dev» 6.x-1.x-dev

Sounds like I need to change the weight on my module so it runs near the end.

 
 

Drupal is a registered trademark of Dries Buytaert.