Download & Extend
Issues

overlay doesn't scroll to the right position for URL fragments

Posted by ksenzee on October 30, 2009 at 9:10pm
Project:Drupal core
Version:7.x-dev
Component:overlay.module
Category:bug report
Priority:major
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

From http://drupal.org/node/610234#comment-2202806 :

6. The #id fragments on the permissions page do not work correctly in the overlay. So for example, if you click on "Help" in the toolbar, then "Taxonomy", then "Configure permissions", it takes you to the permissions page and then seems to flash you down to the correct (taxonomy) portion of the page, but then jumps you right back to the top of the page a second later. I assume this happens when the URL fragment parsing code kicks in, but not sure.

Login or register to post comments

Comments

#1

Posted by ksenzee on December 3, 2009 at 12:56am
Title:Overlay: Existing URL fragments are broken» Existing URL fragments are broken
Component:other» overlay.module

Retitling and un-tagging.

#2

Posted by seutje on December 4, 2009 at 6:05pm

looks like forcing the right src on $('#overlay-element') (entire path like http://example.com/foo#bar) seems to fix it, for FF 3.5.5 at least

note #567754: Wrong anchor adjustment in tableheader.js which might make it seem not to work

#3

Posted by casey on December 23, 2009 at 11:09pm

Reminder to write a patch for this.

#4

Posted by casey on December 24, 2009 at 1:02am

Three-line-fix.

AttachmentSizeStatusTest resultOperations
overlayanchors.patch734 bytesIdlePassed on all environments.View details

#5

Posted by casey on December 24, 2009 at 1:02am
Status:active» needs review

#6

Posted by ksenzee on December 24, 2009 at 1:54am
Status:needs review» reviewed & tested by the community

Lovely. Another bug bites the dust.

#7

Posted by seutje on December 24, 2009 at 6:21am

I guess that works too o.O

#8

Posted by casey on December 24, 2009 at 10:07am

This is committed?

#9

Posted by tobiasb on December 24, 2009 at 10:24am
Status:reviewed & tested by the community» fixed

right, http://drupal.org/cvs?commit=306108

#10

Posted by seutje on December 25, 2009 at 2:13am
Title:Existing URL fragments are broken» doesn't scroll to the right position for URL fragments
Status:fixed» needs work

Is it possible that the height of the toolbar is counted twice?

clicking the permissions for image resulted in this which seems to be exactly the height of the toolbar

I apologise if this isn't the correct issue for this

#12

Posted by casey on December 28, 2009 at 11:14pm

You're right. we should substract sum of heights of elements with overlay-displace-top class.

#13

Posted by casey on June 8, 2010 at 6:14pm
Status:needs work» fixed

Should be fixed since #668640: Overlay shouldn't be based on jQuery UI Dialog.

#14

Posted by System Message on June 22, 2010 at 6:20pm
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

#15

Posted by moshe weitzman on July 23, 2010 at 5:42pm

Is there any way a bright person here could fix this even without the overlay? if one goes to /admin/people/permissions#module-filter, the filter grouping is obscured by the toolbar. Its not that bad n perm page, but it gets debilitating in other places ... Sorry for the noise here.

#16

Posted by casey on July 23, 2010 at 7:14pm

#787940: Generic approach for position:fixed elements like Toolbar, tableHeader

#17

Posted by Bojhan on February 6, 2012 at 9:18pm
Priority:normal» major
Status:closed (fixed)» active

Its not fixed, and we have seen from various people in our module page interviews - that they consider this functionality useless due to it.

I am marking this major, because its a pretty important function of the module page and it now does not work.

#18

Posted by xjm on February 6, 2012 at 11:31pm
Title:doesn't scroll to the right position for URL fragments» overlay doesn't scroll to the right position for URL fragments
Version:7.x-dev» 8.x-dev

#19

Posted by David_Rothstein on February 8, 2012 at 1:52pm
Version:8.x-dev» 7.x-dev
Status:active» closed (fixed)

An issue for this regression was already opened a while ago at #1129578: Overlay doesn't scroll to the right position for anchor links.

Not sure if we need a dedicated issue (in the toolbar module) for Moshe's comment in #15...