CVS edit link for rkrajeshkumar87

I Am an user of Drupal for the past one year. I love drupal and i would like to contribute a lot to drupal.

I am very much interested in the Drupal theming so first i would like to contribute a theme (Zen Subtheme)

In future i would like to contribute modules too).

CommentFileSizeAuthor
#7 iyakkam.tar_.gz131.44 KBrkrajeshkumar87
#4 iyakkam.tar_.gz132.37 KBrkrajeshkumar87
#1 iyakkam.tar_.gz132.52 KBrkrajeshkumar87

Comments

rkrajeshkumar87’s picture

rkrajeshkumar87 commented
Assigned: Unassigned » rkrajeshkumar87
Status: Postponed (maintainer needs more info) » Needs review
StatusFileSize
new iyakkam.tar_.gz132.52 KB

I have attached Zen sub theme along with this thread which need to be reviewed.

Thank You
--
Regards
Rajesh

rkrajeshkumar87’s picture

rkrajeshkumar87 commented
Assigned: rkrajeshkumar87 » Unassigned
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Issue tags: +Theme review
rkrajeshkumar87’s picture

rkrajeshkumar87 commented
StatusFileSize
new iyakkam.tar_.gz132.37 KB

Small Tweaking in CSS updated

rkrajeshkumar87’s picture

rkrajeshkumar87 commented

I have set up a domain for demonstration please check the following link for testing
http://rkrajeshkumar.in/cwdr/

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs review » Needs work 
  1. scripts[] = js/jquery.js
scripts[] = js/jquery.innerfade.js

    There is no need to report jquery.js between the theme scripts, as it is always loaded from Drupal.

  2. Files available from third-party sites should not be included in Drupal.org CVS. 
  3. ;Information added by drupal.org packaging script on 2009-02-13
;---------------------------------------------------------------

version = "6.x-1.0"
core = "6.x"
project = "zen"
datestamp = "1234555897"

    That part needs to be removed, as it is already added by the packaging script.

rkrajeshkumar87’s picture

rkrajeshkumar87 commented
Status: Needs work » Needs review
StatusFileSize
new iyakkam.tar_.gz131.44 KB

The Changes are fixed. Small Tweaking is also updated.
This site is built focussing on trustees and for public helping organisations

rkrajeshkumar87’s picture

rkrajeshkumar87 commented
Priority: Normal » Critical
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Priority: Critical » Normal
Status: Needs review » Needs work

See what I reported on my previous comment.

sreynen’s picture

sreynen commented

It looks like most of the previous comment's issues have been changed. The part that hasn't, as far as I can tell, is the inclusion of 3rd party code. Specifically, jquery.innerfade.js looks to be written by someone else.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs work » Closed (won't fix)

The OP has not uploaded the changed code. I am marking this report as won't fix.