Posted by isopharius on October 31, 2009 at 8:05am
| Project: | OG Forum |
| Version: | 6.x-2.1 |
| Component: | User interface |
| Category: | bug report |
| Priority: | normal |
| Assigned: | paulbooker |
| Status: | closed (fixed) |
Issue Summary
is it possible to make the og local tasks menu aka "tabs" appear inside the og forum?
ie. when someone accesses the "forums" tab, the tabs should still be there to navigate the group pages
Comments
#1
Yeah your right the tabs should really be displayed on the forum page, this is really annoying especially if your using og_panels.
#2
+1 any chance of this??
i have about 10 tabs on my group pages and this is the only one that loses the group tabs.
my guess would be that format of url for others is:
/node/[gid]/og/[tab]
except for forum which is
/node/[gid]/forum
#3
but looking at the menu hook for og_forum, /node/[gid]/forum simply does a drupal_goto to forum/[tid] which is url_aliased to forums/[group name]
but it is the forum/[tid] part which won't match the other paths (/node/[gid]/og/[tab]) which is why tabs disappear.
not sure how easy a fix it could be - perhaps get rid of the goto and do a page view callback that returns the forum contents??
i am guessing not that simple though - but taking a look.
#4
well it was easy enough to get the main Forums page to show with the tabs: http://screencast.com/t/OWM5YWNj
it just takes a couple minor tweaks to the _menu code in og_forums - but all the other forum pages are still missing group tabs; so this alone isn't really worthy of a patch.
I think after initial forum page the remaining pages like topics and add new forum, etc are all set up via the core forum.module.
not too hard to mimic these pages by adding new _menu code for them in og_forum (as i did for top forum page) but will also have to sort out how to manipulate the links that these are all arrived from as these are all defined within the forum.module.
will continue to wander down this path until it gets too messy.
#5
ok, well enough of this little experiment for tonight.. but this little patch adds Group Tabs to the main group forums landing page as well as the forum pages.
breadcrumbs seem correct, but url aliasing would need to be adjusted - but then all the views created tabs don't seem to support aliasing very well anyway.
not sure i quite know what i am doing.. but perhaps this is a working start to get this moving as clearly a long standing bug in og_forums.
also, haven't looked at the post ADD page yet which should also "remain within the group"
#6
just realized that all of this code is doable outside the og_forum module - so i guess, if this isn't considered a bug, and therefore not committed - easy enough to do in a separate module.
#7
#8
Thanks for the work done here. Reviewing the patch now ..
Best,
Paul Booker
Appcoast
#9
+1 Like it! Could i get another positive review and ill commit to the development branch
Best,
Paul Booker
Appcoast
#10
now if i could only get the "add a post" form to retain the tabs - but this is symptomatic of all node types and OG
in general i think that "group tabs" are not entirely a supported concept for OG - which is too bad as they seem like an obvious feature within a group. Even though i have been able to get View tabs to show; still a lot of hoops to jump through and in the end i still don't have a perfect solution
#11
Committed to the development branch.
#12
#13
Please confirm that this patch resolves our current problems with loading forums/ and forums/X
that do not have a group context.
Best, Paul
#14
yup, that makes sense.. tested in og context and works fine.
have just noticed that going to the actual post still loses tabs - i'll need to sort that out next.
#15
Thanks, i have committed this patch and created a new release.
#16
Automatically closed -- issue fixed for 2 weeks with no activity.
#17
// subscribing.