The notification not contains the question itself (like before), and the link to the faq node is http://example.com/faq_ask/answer/

CommentFileSizeAuthor
#3 faq_ask.expert_mail_619624.patch1.24 KBpingers
#2 faq_ask.expert_mail.patch1.19 KBpingers

Comments

pingers’s picture

pingers commented

This is because the email is being sent using a form submit handler, before node_save has been called, so there's no nid for the email to reference.
Should be using nodeapi 'save' instead.
Writing a patch as right now.

pingers’s picture

pingers commented
Status: Active » Needs review
StatusFileSize
new faq_ask.expert_mail.patch1.19 KB

Okay, here's my patch...

It just moves the submit handler into hook_nodeapi 'insert' and 'update'. Yay.

pingers’s picture

pingers commented
StatusFileSize
new faq_ask.expert_mail_619624.patch1.24 KB

Apologies... missed the node type case... doh!

Fixed.

izmeez’s picture

izmeez commented

I am having trouble with this patch:

A carriage return after the username comma would be nice.

The email includes the category it has been posted to but only gives the tid as a numeric not the text of that category.

I'm not sure about including the username of the person asking the question, but that might be fine.

Carriage return before and after the question would be easier to read.

Most importantly, the link "directly to the question" points to the path /faq_ask/answer/xxx and this gives an "Access denied". If the link returned /node/xxx it would work just fine.

Thanks,

Izzy

stenjo’s picture

stenjo commented

Not mutch has happened here. Latest patch in #198828: Notify Asker on answer does fix this issue. Try that one out.

stenjo’s picture

stenjo commented
Version: 6.x-2.0 » 6.x-2.x-dev
Assigned: Unassigned » stenjo
Status: Needs review » Fixed

In my installation using 6.x-2.x-dev version this is fixed.
If the problem still persists, please reopen and add information.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.