Avatars don't show if the site's guestbook is accessed via http://www.mysite.com/guestbook/0 . The url to the avatar image is generated incorrectly as http://www.mysite.com/guestbook/files/pictures/picture-1.jpg

When accessing the site's guestbook via http://www.mysite.com/guestbook (without trailing '/0') all is fine and avatars appear, since their urls are now generated correctly as http://www.mysite.com/files/pictures/picture-1.jpg (i.e. without the 'guestbook' in the path).

Another related small issue: accessing the site's guestbook via main menu gets you to http://www.mysite.com/guestbook (avatars are shown), but after you add an entry to the book you are redirected to http://www.mysite.com/guestbook/0 (and avatars disappear).

Comments

lucky a’s picture

lucky a commented

I forgot to mention that the issue described in the last paragraph appears when only the site guestbook is enabled, in which case the navigation menu entry sends you directly to the main guestbook.

hba’s picture

hba commented
Assigned: Unassigned » hba
Status: Active » Fixed

I have just commited a fix for this. Thanks for the bug report!

lucky a’s picture

lucky a commented

Since updated files are not available via cvs, could you please explain how to patch the guestbook module properly?

I copied the diffs btw 1.1.8.4 and 1.1.8.5 generated for patch from the cvs messages page (am I correct to assume 4.7.0 is 1.1.8.4?), but the patch failed with the following message:

Hmm... Looks like a unified diff to me...
The text leading up to this was:
--------------------------
|--- guestbook.module 2006/05/04 12:13:43 1.1.8.4
|+++ guestbook.module 2006/05/05 07:41:08 1.1.8.5
--------------------------
Patching file guestbook.module using Plan A...
Hunk #1 failed at 537.
Hunk #2 failed at 591.
2 out of 2 hunks failed--saving rejects to guestbook.module.rej
done

What am I doing wrong? Your help is much appreciated! Thanks!

hba’s picture

hba commented

The files are available in the DRUPAL-4-7 (not HEAD) branch in the CVS repository. A tarball of this is generated nightly, just download http://ftp.osuosl.org/pub/drupal/files/projects/guestbook-4.7.0.tar.gz

You can also download the guestbook.module file directly from CVS, with this link: http://cvs.drupal.org/viewcvs/*checkout*/drupal/contributions/modules/gu...

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)