Add help text underneath files on how to apply patches that links to documentation

I've spoken to dww on IRC and we're both thinking this might be better off in the Drupal.org infrastructure module.

Setting back to 'needs work'.

Oops, wrong project.

Patch on the drupal.org module, 6--1 branch.

The hackery is necessary as far as I can tell, because there's no other way to get extra stuff into theme_comment_upload_attachments() / template_preprocess_comment_upload_attachments(). It's a while since I looked at this, but there wasn't a cleaner way.

And AFAIK there's no way of getting to the end of the attachments table. It's also fairly rare to have two patches on a single comment, so if anything putting the link after the table is just going to look odd on all the singletons.

See http://drupalcode.org/viewvc/drupal/contributions/modules/comment_upload...

Having spoken on IRC, here's an alternative approach:

- add a description of the attachments table to comment_upload's template file (which alone does absolutely nothing).
- set that when there is at least one patch or diff file.

Would need some CSS in the site theme to make the link in the P smaller, maybe look like grey form description text?

The above method is probably obsolete.
It was written before we had patch testing. pift_comment() gets extra links in by doing a preg_replace() to remove the original comment attachment table (!!!!).

I guess if we're already committed to using a preg_replace, we could have a module that does this and then invokes a hook to request extra links. Then pift would provide some and so would the drupalorg module.

Yup, so to expand on my earlier post, I reckon the way to do this is:

- cope the preg_replace() technique from pift_comment into a new project_issue_comment().
- instead of just calling a theme function to make the table, this should invoke a new hook to request extra content to put into the comment upload table. Possibly drupal_alter() the table's data structure before it's passed to theme_table()?
- pift module then adds its information and links using this hook
- the Drupal.org customizations module also implements this hook to add the patch help link

Obviously quite a bit of work, so it would be good to get some sort of approval of the plan by the maintainers first :)

Sorry, didn't mean to change the status.

That looks super! :)

> I suggest adding a little bit of logic to verify there's an actual patch file before outputting it

There's that logic in patch #6, which can be reused.

It looks like the way to do this without hacking nodechanges module would be to either implement the alter hook or do a theme preprocess:

      if (!empty($files)) {
        $rows = _nodechanges_get_file_rows($files);
        $element = array(
          '#theme' => 'nodechanges_field_formatter_file_view',
          '#field_name' => $field_name,
          '#files' => $files,
          '#rows' => $rows,
          '#header' => array(t('Status'), t('File'), t('Size')),
        );
        drupal_alter('nodechanges_file_changes_element', $element, $context);
      }

-- that's in nodechanges_field_formatter_view().