This introduces a compile_field helper function. Just some code moved around and moved two local vars into properties.I do not think there is a wildspread need for this to be separated out but it does not hurt anyone and helps me :)

CommentFileSizeAuthor
#4 compile_field.patch3.87 KBdawehner
compile_field.patch3.13 KBchx

Comments

dawehner’s picture

dawehner
Primary language German
commented

Patch looks fine.

Additional it does not brake my 20 test views :)

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

Updating status

merlinofchaos’s picture

merlinofchaos commented
Status: Reviewed & tested by the community » Needs review

No longer applies due to the GROUP BY patch landing. Sorry.

dawehner’s picture

dawehner
Primary language German
commented
StatusFileSize
new compile_field.patch3.87 KB

Here is a first patch. My basic views worked wel..

merlinofchaos’s picture

merlinofchaos commented
Version: 6.x-3.x-dev » 7.x-3.x-dev
Status: Needs review » Patch (to be ported)

Committed to 6.x-3.x -- must be ported to 7.x now

dawehner’s picture

dawehner
Primary language German
commented
Status: Patch (to be ported) » Fixed

This was part of groupby

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.