There are many strings that cannot seem to be localized in this module. Before messing up with the code looking for missing t() calls I'd rather ask whether this is because the text comes directly from Amazon or not. It *would* seem that it's local, for example, I find two strings for "Item Description", both originating in /admin/build/modules and clearly belonging to the Store. Yet, no matter how I localise them, they will stubbornly show up in English.

Things get even worse because I'm using the French locale, so it's actually a mesh of French and English. Any hint?

Comments

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented
Status: Active » Postponed (maintainer needs more info)

You will have to talk specifics to get much help.

Most of the Amazon API stuff will possibly come out in the language the Locale is set to.

Please note that the tpl.php files are available for changing many, many of the language issues. Since they're themable, they're not wrapped with t().

Patches are welcome, and specific examples are welcome. However, this report isn't enough to be able to do much.

Bèrto ëd Sèra’s picture

Bèrto ëd Sèra commented

okay, I'll dig into the sources and will let you know

Thanks

Bèrto ëd Sèra’s picture

Bèrto ëd Sèra commented
Assigned: Bèrto ëd Sèra » Unassigned

I seem to have a decent result, although I'm not sure it's 100% complete. We are checking it in German and Piedmontese (which uses material from the French Amazon locale) at the moment. Apart from inserting missing t() calls I had to make changes in the module itself, as sometimes it was passing HTML in the t() function (which is illegal for the localisation UI, so you end up being unable to localise the expression). I also broke some expressions that where too long and made it hard to find the value in the localisation UI.

The main residual problem seems to be that you used bitmaps for checkout to cart etc, which are not localisable unless we ask all linguistic versions to make their own. I'm thinking of either making it an "update your bitmap" thing (would be nice, but I'm a bit too overscheduled for that as is), or to simply drop the bitmaps in exchange for a CSS localisable thing. Once we decide this I'll upload you the final version.

Our problem is maybe very specific, but on the other hand I think it may affect anyone running a multisite (23 sites in our case, with 11 languages involved). The update mechanism makes it a bit clumsy if you have to make 20+ times the same thing to update a package that (being alpha) is supposed to change quite frequently in the coming months.

Apart from that, it takes ~2 hours to fully localize an Amazon store from scratch, and being closer and closer to Xmas I should think that people will appreciate the chance of doing it, just as we did.

Great module! Our compliments.
Berto

Bèrto ëd Sèra’s picture

Bèrto ëd Sèra commented
Assigned: Unassigned » Bèrto ëd Sèra
rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented
Assigned: Unassigned » Bèrto ëd Sèra

Please make sure to contribute back the .pot file to the module so others don't have to do it!

The graphics are replaceable using the .tpl.php files, which I believe is the only place they're referred to.

Please give me a patch that takes care of the missing t() calls! If you don't know how to make one, which is a great thing to learn (http://drupal.org/patch), then I will accept the changed files themselves as a tar.gz or zipfile. However, a patch is far better.

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented
Status: Postponed (maintainer needs more info) » Fixed

No response on this forever, so I'm marking fixed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.