Add 'access RSS feed' permission to control access to RSS feeds [#62007]

Comment	File	Size	Author
#6	rss_1.patch	2.41 KB	RobRoy
#5	62007_node.module_r1.701_3	2.96 KB	AjK
#4	62007_node.module_r1.701_2	1.61 KB	AjK
#3	62007_node.module_r1.701	844 bytes	AjK

Comment #1

David Hull commented 2 June 2006 at 05:06

This is probably an instance of the problem discussed in http://drupal.org/node/28337.

Log in or register to post comments

Comment #2

magico commented 18 September 2006 at 11:53

Version:	4.7.0	» x.y.z
Priority:	Minor	» Normal

A clean install of Drupal HEAD also has this bug.
When trying to use ?q=node/feed it shows the same page as ?q=node

Log in or register to post comments

Comment #3

AjK commented 19 September 2006 at 14:13

Status	File	Size
new	62007_node.module_r1.701	844 bytes

Odd one this. I have three sites, a live DRUPAL-4-7, a test DRUPAL-4-7 and a test DRUPAL-HEAD.

node/feed works for my live site but not my two test sites. I ran a cvs status to see what the difference was between the two DRUPAL-4-7 sites and there doesn't appear to be any difference! But there is one subtle one I know of. My live site runs PHP4 and my test sites run PHP5.

Anyway, moving on, the attached patch "pushs" this functionality back into HEAD. Note, after applying the patch you need to clear the menu cache by visiting admin/build/menu

Log in or register to post comments

Comment #4

AjK commented 19 September 2006 at 14:26

Status:

Active

» Needs review

Status	File	Size
new	62007_node.module_r1.701_2	1.61 KB

In #1 David Hull points to http://drupal.org/node/28337 The end of this Dries says that a permission should exist (called 'RSS feed') that allows for this feature to be disabled.

The attached patch is the same as my previous one (in that it addes this functionality into HEAD) but it also adds a permission called RSS feed and both node/feed and rss.xml take the permission into account.

Now, this new patch adds a new permission and since we are in code freeze I don't expect this patch to get through. Depends whether it's percieved a bug or a feature. I guess the user community can decide that by feedback on this issue.

regards
--AjK

Log in or register to post comments

Comment #5

AjK commented 19 September 2006 at 14:44

Status	File	Size
new	62007_node.module_r1.701_3	2.96 KB

and this patch (as per the disable RSS issue thread) removes the syndicate icon if the user doesn't have RSS permissions

Log in or register to post comments

Comment #6

RobRoy commented 27 October 2006 at 01:12

Status	File	Size
new	rss_1.patch	2.41 KB

Fixed up a few things:

- Perm is now called 'access RSS feed' to be more clear
- Don't insert a node/feed menu item since that should be an alias of rss.xml and perms will get filtered through that way.

Thanks AjK. Reviews?

Log in or register to post comments

Comment #7

RobRoy commented 27 October 2006 at 01:14

Title:

Node Feed Not Working

» Add 'access RSS feed' permission to control access to RSS feeds

Better title...

Log in or register to post comments

Comment #8

coreb commented 30 November 2006 at 01:29

Version:

x.y.z

» 4.7.x-dev

Moving out of the "x.y.z" queue to a real queue.

Log in or register to post comments

Comment #9

RobRoy commented 30 November 2006 at 03:25

Version:

4.7.x-dev

» 5.x-dev

Will get more attention on 5.x.

Log in or register to post comments

Comment #10

joshk commented 30 November 2006 at 03:36

Applied clean, works as advertised.

However, the access should probably be "on" by default, or else a notice set that content is not being syndicated. Most folks take it for granted that their CMS is producing feeds.