Posted by wesku on November 1, 2009 at 12:52pm
| Project: | AddThis |
| Version: | 6.x-3.x-dev |
| Component: | Code |
| Category: | feature request |
| Priority: | normal |
| Assigned: | wesku |
| Status: | closed (fixed) |
Issue Summary
Hello,
Thanks for creating and maintaining this lovely module. What I would like to do is have a display like the "Default Styling" found at http://www.addthis.com/help/toolbox. Is this possible? If so, how would I accomplish this?
thanks for all your work on this,
Dale Geist
Comments
#1
I posted this here for Dale. I think this is a feature we will be supporting in the future. However we first need to upgrade to Addthis.com API 2.0 and also make a Drupal 7 port of the module.
#2
+1
#3
It would be great to have this feature. Please do that :)
#4
I've created a patch to do this, is working, there's only one problem with this.
The toolbox uses code to create the icons/links like this:
<a class="addthis_button_twitter"></a><a class="addthis_button_facebook"></a>
you can add and remove any social network you want, is very easy. The patch prints some of them (the most popular) but not all of them, if you use this patch, I would recommend to override the theme function in your template.php and add as many icons/links as you want.
I would like to hear the author's module opinion about this.
I could do a huge patch to add options and present the user a nice settings page to add/remove icons but since I don't know if this is gonna be committed, I don't know if the time invested will be the best thing to do.
One last thing you should know.
I needed the functionality in this patch #304753: View's url and title shared instead of node's so I already added it. You could remove this if you want even manually from my patch, is just a couple of lines (omit the first 8 lines of the patch).
Please test
#5
Support for the Addthis Toolbox would be a great enhancement to this module!
#6
@bhirsch did you try the patch in #4?
#7
Hi,
Worked fine for me. Brilliant!
Victoria
#8
We are now working on 3.0 version of this module. This will be a major update to Addthis.com API 2.0. Current version uses old API and I will include this patch to next version of the module. Only 3.0 version will be released to D7, so we need to do a full working release before D7 is out.
#9
Absolutely fabulous... thank you SO MUCH for this patch. You've made my day... making something simple that looked like it was going to be lots of work. :) :)
#10
This sounds great, but I'm a bit confused (sorry!)... Has support for AddThis toolbox been added to the module yet, or will that support only be added in the D7 version? It'd be great to have it in a D6 version. Thanks!
#11
Apparently, Addthis toolbox will only be available for D7 in the 3.0 version of this module. If the owner of this module doesn't want to support this, maybe a solution would be to create another module with this functionality only. I might be interested in creating a module for this, but *only* if we're not duplicating efforts.
Honestly, I think it would be a lot easier just to apply the patch to the 2.x-dev version.
#12
If the maintainer doesn't want to add it, just use the patch above while you're waiting for the new version to come out.
#13
but if the maintainer doesn't add the patch, we'll have to create another patch for the new version, that's always a pain in the %$&
#14
Ah, but the maintainer has said that this functionality will be in 3.0. Anyway, take it or leave it—the patch above is working great for me. :)
#15
@dbabbage yes, but @allanhoffman was saying that it would be cool to have this on 2.x since 3.0 will only be for D7..
by the way.. I made the patch.
#16
3.0 will be also for bot D6 and D7 and it will replace the 2.x for everything but D5.
Reason for not adding this already in 2.x versions is purely amount of extra work it would generate. We are anyway currently building an improved version of the module and any new major features to 2.x always generate a lot of new issues + support. We simply don't have enough people working on the module to work on both 2.x and 3.x versions. Sorry.
#17
that's a reasonable and perfect explanation... some of us were thinking that 3.x will be only for 7.x.. thanks..
#18
Rerolled the patch from #4, and reworked it a little to automatically add icons for the services chosen on the addthis admin settings page.
#19
Applied #18.
Had to apply #304753-6: View's url and title shared instead of node's to solve getting [URL] [TITLE] position holders shown on Twitter etc. instead of real url and title when used as link on node.
Otherwise whizzo, thanks!
#20
Official support for the AddThis toolbox will have to wait for the 6.x-3.x branch, as stated above.
That said, there is an unofficial candidate starting point for a 6.x-3.x branch in #735688: AddThis 3.0 dev candidate. Any comments you can add there would help move this along.
#21
I look forward to the support of the toolbox in D6
#22
Toolbox is now supported in latest dev version. It might get backported to 2.x versions later.
#23
Automatically closed -- issue fixed for 2 weeks with no activity.