notice: Undefined variable: output in image_attach_views_handler_field_attached_images.inc
unjello - November 1, 2009 - 14:47
| Project: | Image |
| Version: | 6.x-1.x-dev |
| Component: | image_attach |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed |
Description
After attaching an image to a Story, while displaying a listing created with Views2 I got this message. Workaround attached.
| Attachment | Size |
|---|---|
| image_attach_views_handler_field_attached_images.patch | 524 bytes |
#1
Is that with E_ALL?
Grr why can't PHP by a bit more laid back about these things? :(
Thanks for taking the time to roll a patch.
However, since $output is only set once (just in 3 different places depending on your flow), I prefer a visually cleaner fix -- actually set it rather than append to it. (I just tend to append when coding to avoid data clobbering bugs if I rearrange stuff...)
Could you test the attached please and confirm it also fixes your bug?
I can then commit it :)
#2
ay, that does the trick too... and i agree it looks better. i just went for whatever removed the warning in fastest way :]
#3
Committed to CVS.
Thanks for reporting and making a patch!
#4
Automatically closed -- issue fixed for 2 weeks with no activity.