services patch for d7
| Project: | Services |
| Version: | 7.x-1.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | needs work |
Jump to:
So, this patch just fixes some issues in the browser, but prepares the field for the rest of the patches I've submitted.
To be able to test the services functionality, the patches in these issues should also be applied:
#620568: user_service patch for D7
#620552: system_service patch for D7
There are two .test files, one if for unit testing of services module and the other is a real xmlrpc client test case. The services.test file will blow up when testing the crossdomain.xml menu entry due to dependencies with services_keyauth. I deliberately left this code so we can be noticed about the error.
The main goal of these three patches is run without errors the 'services_xmlrpc.test' test case.. a real xmlrpc client for the system and user services.
Again, my intention with these patches is not to have a 1.0 release of services for d7, so I just focused on make the xmlrpc client test pass. With this step complete I guess we have made a great improvement in d7 update, even if some of the functionalities are broken (access callback and arguments, for example, I decided to leave them disabled for now).
| Attachment | Size |
|---|---|
| services_d7_ilo_1.patch | 13.11 KB |
#1
mm I forgot to mention.. needs review.
#2
oh.. sorry, now I do understand why I was facing errors using the xmlrpc testcase. I forgot that simpletest uses a unique string in the HTTP header to make switching of databases, and the xmlrpc client does not, therefore no matter what you change in the .test file, the xmlrpc client will connect to the real drupal database.
I have to go back and start using the xmlrpc testing class I wrote days ago. I'll submit new testcases using this class.
#3
Some of this was brought up in the other issue but to consolidate it here:
- I'd like to see the tests come out for now so we can focus for the moment on patches that don't depend on each other. I want to state strongly that I think the tests are vitally important for Services in D7, I just want to keep the patches small and going forward for the moment, just so we can get the basics running first. We should be able to get that cranked out pretty fast. Once those patches are done lets make adding the tests top priority.
- admin/build doesn't work as a menu location anymore in D7 so I moved everything out to admin/config/services. However there is already a core Web Services block, and that would put our settings in with those. I'm not sure if that is what we want. Discuss.
- The one big thing that I think is important to get into this first batch of patches is #616490: Services API misuses hash/number (#) symbols which removes inconsistent hashmarks from services definitions. This patch is very likely going to land in the 6.x branch so it should be brought forward. It is also important to do this now because its a big change that then needs to be done back through all the dependent services. Adding the tests will be a great way to shake out problems in this area.
- We want to pull out the services browser to a new module (as I discussed with ilo who apparently also discussed it with marcingy) but that can wait for a followup patch.
I'll have a patch for all this in the morning, it's not quite ready but I need to sleep.