On admin/structure/taxonomy/1/list, if someone uses drag-and-drop to rearrange their vocabularies, then saves, there is no feedback message.
A drupal_set_message() should display a feedback message such as "Configuration saved."
This also affects the tags page, e.g. admin/structure/taxonomy/1/list (should it be a separate issue?)
This is v. similar to #609108: Menu admin page should say something when you save
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | 620592_taxonomy_admin_page_feedback.patch | 810 bytes | sivaji_ganesh_jojodae |
| #4 | 620592_taxonomy_admin_page_feedback.patch | 1.44 KB | sivaji_ganesh_jojodae |
| #3 | 620592_taxonomy_admin_page_feedback.patch | 1.45 KB | sivaji_ganesh_jojodae |
Comments
Comment #1
lisarex commentedComment #2
webchickLet's use this component rather than the tag. There are lots of other issues like this categorized this way.
Comment #3
sivaji_ganesh_jojodae commentedAttached is a patch which adds an if check and
drupal_set_message()to submit handler of terms overview form (admin/structure/taxonomy/%tid) and vocabularies overview form (admin/structure/taxonomy), prints message like "Your configuration has been saved." when there are one or more changed items.The same behavior exists in d6 so the patch need to be backported.
Comment #4
sivaji_ganesh_jojodae commentedRerolled #3 patch with appropriate variable name.
Comment #5
sivaji_ganesh_jojodae commentedThere is an another usability issue with Taxonomy admin page #641314: Taxonomy term form being rebuilt even after final submit, dropping the link here to get your attention.
Comment #6
lisarex commentedHI sivaji, applied the patch and it works great. If someone else with a codey background can also review and approve, we can get this RTBC'd...
Comment #7
dries commentedTo me, the $is_changed check feels unnecessary. Even if nothing was changed, it is useful to give a status message, IMO.
Comment #8
sivaji_ganesh_jojodae commented+1 for #7. Re-rolled patch displays status message without any check.
Comment #9
webchickAwesome, thank you! :)
Committed to HEAD.
Any chance I could persuade you to look at #609108: Menu admin page should say something when you save while you're here? :D