Taxonomy admin page ... need feedback when saving
lisarex - November 2, 2009 - 01:42
| Project: | Drupal |
| Version: | 7.x-dev |
| Component: | user interface text |
| Category: | bug report |
| Priority: | minor |
| Assigned: | Unassigned |
| Status: | fixed |
| Issue tags: | Novice |
Description
On admin/structure/taxonomy/1/list, if someone uses drag-and-drop to rearrange their vocabularies, then saves, there is no feedback message.
A drupal_set_message() should display a feedback message such as "Configuration saved."
This also affects the tags page, e.g. admin/structure/taxonomy/1/list (should it be a separate issue?)
This is v. similar to #609108: Menu admin page should say something when you save
#1
#2
Let's use this component rather than the tag. There are lots of other issues like this categorized this way.
#3
Attached is a patch which adds an if check and
drupal_set_message()to submit handler of terms overview form (admin/structure/taxonomy/%tid) and vocabularies overview form (admin/structure/taxonomy), prints message like "Your configuration has been saved." when there are one or more changed items.The same behavior exists in d6 so the patch need to be backported.
#4
Rerolled #3 patch with appropriate variable name.
#5
There is an another usability issue with Taxonomy admin page #641314: Clear the term input form when a new term been added., dropping the link here to get your attention.
#6
HI sivaji, applied the patch and it works great. If someone else with a codey background can also review and approve, we can get this RTBC'd...
#7
To me, the $is_changed check feels unnecessary. Even if nothing was changed, it is useful to give a status message, IMO.
#8
+1 for #7. Re-rolled patch displays status message without any check.
#9
Awesome, thank you! :)
Committed to HEAD.
Any chance I could persuade you to look at #609108: Menu admin page should say something when you save while you're here? :D