Bring pollfield up to d6 code standards

OK, I am working on the dev branch. However, as far as I could tell it is identical to the latest beta version except for the .info file. Let me know if there is an even newer version of the dev branch. I will submit a patch for the code standard changes later today.

Here are the patches to bring the pollfield into the Drupal code standards. It's a fairly massive patch because of the changes needed to address indentation and whitespace issues. I made all the recommended coder and coder tough love changes, mostly by hand. So hopefully there aren't any bugs as a result of script based changes. Here's an overview of what I changed:

• tabs to 2-spaces
• fixed indentation to follow logic
• added spaces around all operators ($var='hello' is now $var = 'hello' )
• changed string concatenation to Drupal 6 standards
• removed any trailing whitespace
• put spaces in the correct spaces around curly braces
• aligned conditional statement layout with D6 standards
• expanded some doxygen comments to fit standard
• normalized the use of single and double quotes (tried to get it to where double quotes were only used in SQL and inside HTML strings)
• Made, true, false, and null UPPERCASE

I tried to avoid any logic changes that could affect the operation of the module so that this patch would be simpler to trouble shoot if any bugs arise. It tests out OK on my local install of D6. I can add the pollfield type modify its features in various ways and vote on polls alright. Let me know if you need any more clarification on the changes I've added into the patch.

Woops, I had something go wrong when I created the pollfield .install.patch file. That one is not correct. Please refer to this patch for the install profile.

Cool, let me know if there is anything I can do to help.

@mario_prkos - Looks like you implemented some of the patch changes into your new version, but not all of them. Thanks for that.

What would be the best way to proceed from here to get the module into compliance with the code guidelines? Should I roll a new patch against the 6.x-1.10-beta1 version?

Yes, I will do it against 6.x-dev for sure...I was just trying to specify the new version of 6.x-dev. It seems like mario is keeping dev and the latest version pretty much exactly the same for now.

Here is a patch against dev/1.10-beta1

This resolves all coder issues.

I am going to open up a couple of other specific issues for stuff that I noticed in this process, but that I didn't want to muddy up this patch. This should mostly be changes:
-indentation (spaces not tabs)
-spaces after curly braces
-spaces after commas

Here's one more patch file for you to consider. This includes all of the changes I put into the above patch, but also all the recommended changes from coder_tough_love. I broke this one out separate just beacause I thought you might be reluctant to put all of these changes in at once. Anyways I'll let you take your pick.

Let me know if you need help going through the module. I know this sort of code cleanup can be a tedious process. Maybe we can divide it up in halves? Who knows, maybe that's more work than it's worth. Either way, I can help if you'd like.

Thanks for all the work on this. I went through the coder module and made all the changes directly. It was just easier than reviewing these patches, because of the size of the changes. The entire module in the latest dev branch should be in line with the Drupal coding standards. Going forward we will keep it that way.