Download & Extend

WSOD after upgrade from pre-modalframe version because of not enabled modalframe & jquery_ui

Project:Hostmaster (Aegir)
Version:6.x-0.4-alpha2
Component:Code
Category:bug report
Priority:critical
Assigned:Unassigned
Status:closed (cannot reproduce)

Issue Summary

After upgrading it shows WSOD with PHP error:

PHP Fatal error:  Call to undefined function modalframe_parent_js()
in profiles/hostmaster/modules/hosting/task/hosting_task.module on line 736

Even running update.php doesn't help, because now required modules modalframe & jquery_ui are not enabled yet.

UPGRADE.txt should include something like:

To enable now required two new modules, modalframe & jquery_ui, cd to your Aegir platform root and run drush enable modalframe.

Or add graceful degradation, so user could log-in without WSOD and enable now required modules in the frontend.

Comments

#1

i added an update_x function to enable the modules.

#2

hosting_update_6000

<?php
/**
* Enable the modalframe and jquery_ui modules
*/
function hosting_update_6000() {
 
$ret = array();
 
module_enable(array('modalframe', 'jquery_ui'));
  return
$ret;
}
?>

#3

Status:active» needs review

Is this issue fixed with that patch now?

I don't like the new dependency. :( I think that stuff should be optional in the core.

#4

Adrian tested it yesterday and it worked, afaik.
But now HEAD is broken so I can't confirm that.

#5

it can't be an optional dependency.

the module will need to be there regardless, but it will degrade without javascript.

we also have drush_make now for upgrades, which means that downloading the extra required dependencies is no longer an issue.

#6

Status:needs review» fixed

The php snippet above was already in CVS by the time it was mentioned, so it wasn't really a 'patch'. I'm closing this ticket as I'm confident the issue is fixed - all that remains is the task of updating UPGRADE.txt (once the upgrade path is fixed)

#7

Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

#8

Status:closed (fixed)» active

I still have this problem on a new installation of Aegir. Not sure if something hasn't been pushed out, but it's still not working and dl + en jquery_ui + modalframe fixes the problem.

#9

Status:active» postponed (maintainer needs more info)

I haven't heard of this being reproduced since the 10 months ago that it occurred. The only way I can think of that it could happen is if drush_make failed to fetch jquery_ui and modalframe (i.e, maybe drupal.org was actually down for those few seconds). But then, you'd expect that you were missing admin_menu too. Was that the case?

Did you install aegir 0.4 alpha13?

I just can't see this as a bug that could re-appear, unless it's a bug in drush_make, I install Aegir often 8 times a day and it never occurs for me.

Can you try and reinstall 0.4alpha13 and at least see if you can reproduce it each time? Then maybe we can identify a problem with your system when using drush_make

#10

Status:postponed (maintainer needs more info)» closed (cannot reproduce)

I'm going to have to close this as I can never reproduce. There may have been an issue with downloading modules from drupal.org at the time you installed ( a limitation of drush make since it always requires working network/drupal.org to fetch packages), in which case you'd be missing admin_menu as well.

Please do reopen if you can debug this any further, but it sounds like a one-off to me I'm afraid, or relevant dependencies weren't present to fetch and unpack the modules.

The enabling of the dependencies in a hook_update has been present for 12 months now