WSOD after upgrade from pre-modalframe version because of not enabled modalframe & jquery_ui
omega8cc - November 2, 2009 - 04:53
| Project: | Hostmaster |
| Version: | 6.x-0.4-alpha2 |
| Component: | Code |
| Category: | bug report |
| Priority: | critical |
| Assigned: | Unassigned |
| Status: | closed |
Jump to:
Description
After upgrading it shows WSOD with PHP error:
PHP Fatal error: Call to undefined function modalframe_parent_js()
in profiles/hostmaster/modules/hosting/task/hosting_task.module on line 736Even running update.php doesn't help, because now required modules modalframe & jquery_ui are not enabled yet.
UPGRADE.txt should include something like:
To enable now required two new modules, modalframe & jquery_ui, cd to your Aegir platform root and run drush enable modalframe.
Or add graceful degradation, so user could log-in without WSOD and enable now required modules in the frontend.
#1
i added an update_x function to enable the modules.
#2
hosting_update_6000
<?php/**
* Enable the modalframe and jquery_ui modules
*/
function hosting_update_6000() {
$ret = array();
module_enable(array('modalframe', 'jquery_ui'));
return $ret;
}
?>
#3
Is this issue fixed with that patch now?
I don't like the new dependency. :( I think that stuff should be optional in the core.
#4
Adrian tested it yesterday and it worked, afaik.
But now HEAD is broken so I can't confirm that.
#5
it can't be an optional dependency.
the module will need to be there regardless, but it will degrade without javascript.
we also have drush_make now for upgrades, which means that downloading the extra required dependencies is no longer an issue.
#6
The php snippet above was already in CVS by the time it was mentioned, so it wasn't really a 'patch'. I'm closing this ticket as I'm confident the issue is fixed - all that remains is the task of updating UPGRADE.txt (once the upgrade path is fixed)
#7
Automatically closed -- issue fixed for 2 weeks with no activity.