Division by zero after editing product kits that are already in the cart

I am hiving this issue, did you ever resolve it?

Make sure that on your product kit you have a value greater than zero for the discount amount.

Not sure if that is a bug but when entering decimals in a form drupal or the discount mechanism reset value to 0.00 after saving.

Jan 25 - 2011
Drupal 6.20, Ubercart 2.4

I have encountered this bug multiple times this week, both with my administrator account and a fresh test account, using fresh test product kits.

Overall, the main thing that seems to be happening is if you EDIT A KIT and ADD A COMPONENT to a kit, but the kit already exists in any users' cart, this is when all the problems seem to happen. The next time that user views or updates their cart, they will see varied combination of effects, like:

---Frequently happens: A red error message will appear on top of the cart page, always having to do with "Division by zero" in uc_product_kit.module around line 1113 or so --- OR --- "warning: Invalid argument supplied for foreach()" in uc_cart.module around line 1599.

---Frequently happens: Cart is completely blank. Upon clicking 'update', they will get the red error message stated above.

---Frequently happens: Cart total in cart block says something, but when viewing the cart page, the total is empty or a lot less. To put it a different way, it's like ghost products exist in your cart and you can't see them.

---Maybe happens frequently but haven't paid attention to it: For the products/kit components that are still viewable in the cart... the quantity shown will be something crazy like "0.77688" or "56.3455", or sometimes the quantity field will be completely blank.

We've tried messing around with kit component quantities, and other stuff... but have only been able to make the error happen when ADDING a component to a pre-existing kit which happens to be in someone's cart at the time of editing.

If you go back to the kit edit page, and take away that recently added component, the cart returns to normal (upon clicking Update Cart of course).

I hope this gets fixed!!

In the main time here is what we used to clear the errored cart:

 // Clear cart command, where "1" is user id
uc_cart_empty(1); 

This blows away the cart contents, errored or otherwise. Obviously not a solution, but maybe a helper to someone reading this.

Issue confirmed, not sure what the best fix is though.

Marked #1185120: Cart will not empty and products are unable to be removed individually. as duplicate

Moving to "Product kit" component.

Untagging. Only two issues had the uc_product_kit tag. Now that there's a Product kit component the tag is no longer needed.

@#6

Issue confirmed, not sure what the best fix is though.

I'm not sure either

possible solution: after editing a product kit, check uc_cart_products and correct as needed
BUT: what happens if I have a browser opened with a shopping cart page and I'm updating the quantities of my products meanwhile an admin removes an item from one of the product kits in my cart ?

@#10 for the second part (an admin removes items from a PKit at the time a cart is being updated)

that can be easily handled by uc_product_kit_update_cart_item

uc_product_update_cart_item($p_nid, $product->data, $qty * $kit->products[$p_nid]->qty, $cid);

is just a matter of checking if that $p_nid still belongs to the $kit and if not set its qty to zero

Simplest way to solve this seems to be to remove any matching kits from the cart whenever a kit is updated, same way we do when a kit is deleted. There is no straightforward way to handle product addition or removal at this point, so this seems safest.

#12: 620844-uc_product_kit-update-cart.patch queued for re-testing.

Failure seems unrelated: exception 'DatabaseSchemaObjectExistsException' with message 'Table variable already exists.'

Committed #12 to 7.x-3.x, ported and committed to 6.x-2.x as well.