As required for E-commerce 4.7 we need to get rid of the discounts by role functionality hardcoded in core modules. Also we need to implement the discount API.

This patch strips out the discount by role from core modules and introduce the 'amout' hook for discountapi as required.

At this moment the discount data is not being saved in ec_transaction_misc table as expected and the mappings for role->discount are still being saved to ec_payment_adjust.

The draft for the new role_discount module is in my sandbox.

CommentFileSizeAuthor
#1 ecommerce_discountapi_0.patch8.43 KBrecidive
ecommerce_discountapi.patch9.61 KBrecidive

Comments

recidive’s picture

recidive commented
StatusFileSize
new ecommerce_discountapi_0.patch8.43 KB

Update patch and module. Removed the ec_payment_adjust database table. Now the role_discount module makes use of the brand new product_specials hook and have its own database table (ec_role_discount). The .install script also takes care of loading data from the old table.

gordon’s picture

gordon commented

Thanks, I have commited this.

I have also taken a look at the role_discounts module, and have only 1 concern. The hook_product_specials() can be called by many modules at the same time. So before work out the discount you may want to work out how much discount has already been applied. This is esp. important if you are using % based discounts.

Otherwise you can commit this into the contrib when you are ready.

Good work, thanks.

gordon’s picture

gordon commented
Status: Needs review » Fixed

done.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)