Provide order data as context for uc_price (for multicurrency support) [#621494]

When the Review page is being displayed, the cart checkout pane's rows are run through uc_price, but the order isn't being provided as a part of the context of the call. I'll attach a patch shortly which does this.

Comment	File	Size	Author
#2	ubercart-621494-provide_order_context_to_uc_price.patch	12.08 KB	xurizaemon
#1	ubercart-621494.patch	1.27 KB	jcfiala

Comments

Comment #1

jcfiala commented 2 November 2009 at 23:06

Status:

Active

» Needs review

Status	File	Size
new	ubercart-621494.patch	1.27 KB

So, here's the patch I created to provide an order context to uc_price - please review.

Comment #2

xurizaemon

he/him

Ōtepoti, Aotearoa 🏝

commented 27 July 2011 at 02:33

Title:	Cart Checkout Pane on Review page does not provide order as part of context to uc_price	» Provide order data as context for uc_price (for multicurrency support)
Version:	6.x-2.0	» 6.x-2.x-dev

Status	File	Size
new	ubercart-621494-provide_order_context_to_uc_price.patch	12.08 KB

Re-rolling against current Ubercart and attaching changes from http://www.vintagedigital.net/content/how-add-multicurrency-support-uber... as well.

This patch sets $context['subject']['order'] = $order for each core UC payment module, and in a few other locations where uc_price() might need the contextual data to set price information based on the order details.

The benefit of doing this is that the order can store currency information, and the displayed price reflect the currency which the order occurred in.

I have not looked into why this patch does this, though:

@@ -377,7 +380,7 @@ function uc_payment_get_totals($return = FALSE, $order = NULL) {
 
     $context['revision'] = 'themed';
     $context['type'] = 'amount';
-    unset($context['subject']);
+    unset($context['subject']['line_item']);
     $output .= '<tr><td align="right"><b>'. t('Order total:') .'</b></td>'
               .'<td align="right">'. uc_price(uc_order_get_total($order), $context)
               .'</td></tr></table>';