Call to dsm instead of drupal_set_message in views_handler_field_counter
carlosdavis - November 2, 2009 - 23:27
| Project: | Views |
| Version: | 6.x-3.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | critical |
| Assigned: | matt2000 |
| Status: | closed |
Description
I noticed that I was getting a dead page on any view using the Global: View Result Counter field.
My error logs had:
PHP Fatal error: Call to undefined function dsm() in /home/klat/web/sites/all/modules/contrib/views/handlers/views_handler_field_counter.inc on line 29
I assume that dsm is misused shorthand for drupal_set_message.
#1
Fast fix.
#2
Yup, that's a wrapper from devel module. Looks like debugging that didnt get cleaned up.
This patch removes the unnecessary and problematic line.
#3
Reviewed, the #2 patch fixes the issue.
#4
I can confirm both patches are good.
#5
Ah by the way, this was fixed in the dev version of views 2.
#6
We should mark this as fixed, isn't?
#7
The patch wasn't applied to views-3 yet.
http://drupal.org/files/issues/views-counter-fix.patch
#8
Fixed in 3.x as well.
#9
Automatically closed -- issue fixed for 2 weeks with no activity.