Download & Extend
Views » Issues

Call to dsm instead of drupal_set_message in views_handler_field_counter

Posted by carlosdavis on November 2, 2009 at 11:27pm
Project:Views
Version:6.x-3.x-dev
Component:Code
Category:bug report
Priority:critical
Assigned:matt2000
Status:closed (fixed)

Issue Summary

I noticed that I was getting a dead page on any view using the Global: View Result Counter field.

My error logs had:
PHP Fatal error: Call to undefined function dsm() in /home/klat/web/sites/all/modules/contrib/views/handlers/views_handler_field_counter.inc on line 29

I assume that dsm is misused shorthand for drupal_set_message.

Login or register to post comments

Comments

#1

Posted by dereine on November 3, 2009 at 12:47am
Status:active» needs review

Fast fix.

AttachmentSize
views-counter-fix.patch 854 bytes

#2

Posted by matt2000 on November 3, 2009 at 1:03am
Assigned to:Anonymous» matt2000

Yup, that's a wrapper from devel module. Looks like debugging that didnt get cleaned up.

This patch removes the unnecessary and problematic line.

AttachmentSize
621532_views_handler_field_counter.patch 871 bytes

#3

Posted by Vacilando on November 5, 2009 at 11:13am
Status:needs review» reviewed & tested by the community

Reviewed, the #2 patch fixes the issue.

#4

Posted by ermannob on November 9, 2009 at 12:56pm

I can confirm both patches are good.

#5

Posted by dereine on November 9, 2009 at 1:21pm

Ah by the way, this was fixed in the dev version of views 2.

#6

Posted by dagmar on November 9, 2009 at 2:55pm
Status:reviewed & tested by the community» fixed

We should mark this as fixed, isn't?

#7

Posted by dereine on November 9, 2009 at 3:26pm
Version:6.x-2.7» 6.x-3.x-dev
Status:fixed» needs review

The patch wasn't applied to views-3 yet.
http://drupal.org/files/issues/views-counter-fix.patch

#8

Posted by merlinofchaos on November 9, 2009 at 9:30pm
Status:needs review» fixed

Fixed in 3.x as well.

#9

Posted by System Message on November 23, 2009 at 9:40pm
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.