I noticed that I was getting a dead page on any view using the Global: View Result Counter field.

My error logs had:
PHP Fatal error: Call to undefined function dsm() in /home/klat/web/sites/all/modules/contrib/views/handlers/views_handler_field_counter.inc on line 29

I assume that dsm is misused shorthand for drupal_set_message.

CommentFileSizeAuthor
#2 621532_views_handler_field_counter.patch871 bytesmatt2000
#1 views-counter-fix.patch854 bytesdawehner

Comments

dawehner’s picture

dawehner
Primary language German
commented
Status: Active » Needs review
StatusFileSize
new views-counter-fix.patch854 bytes

Fast fix.

matt2000’s picture

matt2000 commented
Assigned: Unassigned » matt2000
StatusFileSize
new 621532_views_handler_field_counter.patch871 bytes

Yup, that's a wrapper from devel module. Looks like debugging that didnt get cleaned up.

This patch removes the unnecessary and problematic line.

vacilando’s picture

vacilando commented
Status: Needs review » Reviewed & tested by the community

Reviewed, the #2 patch fixes the issue.

ermannob’s picture

ermannob commented

I can confirm both patches are good.

dawehner’s picture

dawehner
Primary language German
commented

Ah by the way, this was fixed in the dev version of views 2.

dagmar’s picture

dagmar
Primary language Spanish
Location Argentina
commented
Status: Reviewed & tested by the community » Fixed

We should mark this as fixed, isn't?

dawehner’s picture

dawehner
Primary language German
commented
Version: 6.x-2.7 » 6.x-3.x-dev
Status: Fixed » Needs review

The patch wasn't applied to views-3 yet.
http://drupal.org/files/issues/views-counter-fix.patch

merlinofchaos’s picture

merlinofchaos commented
Status: Needs review » Fixed

Fixed in 3.x as well.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.