Download & Extend

Custom CSS setting goes missing with admin_menu

Project:Nice Menus
Version:6.x-2.x-dev
Component:Code
Category:bug report
Priority:minor
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

Install instructions say to set the path to a Custom CSS file in global theme settings.

If you have admin_menu installed and use it to navigate to Site Building > Themes > Configure > Global Settings, it goes to the path /admin/build/themes/settings/global, as opposed to /admin/build/themes/settings which the code expects.

This breaks the code:

      // This is a global setting, so only insert the field
      // on the global settings page.
      if (arg(4)) {
        return;
      }

(nice_menus.module, line 34)

Instead, I would suggest something like:

      if (arg(4) && arg(4) != 'global') {

Comments

#1

Status:active» needs review

I just discovered this bug myself, and happened to patch it exactly the same way. Here's the patch file.

AttachmentSize
nice_menus_global_css_setting.patch 564 bytes

#2

Status:needs review» reviewed & tested by the community

That worked for me; thanks, it took me ages to find what was wrong. I'd recommend this patch get rolled into the current release to spare others the pain!

#3

Version:6.x-1.3» 6.x-2.x-dev
Status:reviewed & tested by the community» fixed

Fixed in HEAD.

#4

Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

nobody click here