Custom CSS setting goes missing with admin_menu

thinkling - November 2, 2009 - 23:48
Project:Nice Menus
Version:6.x-1.3
Component:Code
Category:bug report
Priority:minor
Assigned:Unassigned
Status:needs review
Description

Install instructions say to set the path to a Custom CSS file in global theme settings.

If you have admin_menu installed and use it to navigate to Site Building > Themes > Configure > Global Settings, it goes to the path /admin/build/themes/settings/global, as opposed to /admin/build/themes/settings which the code expects.

This breaks the code:

      // This is a global setting, so only insert the field
      // on the global settings page.
      if (arg(4)) {
        return;
      }

(nice_menus.module, line 34)

Instead, I would suggest something like:

      if (arg(4) && arg(4) != 'global') {

#1

chillin411 - November 11, 2009 - 15:11
Status:active» needs review

I just discovered this bug myself, and happened to patch it exactly the same way. Here's the patch file.

AttachmentSize
nice_menus_global_css_setting.patch 564 bytes
 
 

Drupal is a registered trademark of Dries Buytaert.