Download & Extend
Translation template extractor » Issues

addcslashes to .info

Posted by droplet on November 3, 2009 at 3:28am
Project:Translation template extractor
Version:7.x-1.x-dev
Component:Code
Category:bug report
Priority:critical
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

There isn't addcslashes to .info stings, is it by design ? (Command line extraction)

example:

#: active_n_rebuild/active_n_rebuild.info:0
msgid "[EN] Table-based multi-column extended theme (for Web developers).<br />Work with PHP5 (PHP4 - with no waranty).<br />Copyright &copy; 2009 <a href="http://lynxlab.net" title="Open Lynxlab project (in a new window)" target="_blank">Lynxlab.net</a>"
msgstr ""
Login or register to post comments

Comments

#1

Posted by Gábor Hojtsy on November 3, 2009 at 2:25pm

Wow, we definitely did not expect people to put HTML into their descriptions. Looks like this needs to be fixed indeed.

#2

Posted by JohnAlbin on November 11, 2009 at 9:49am

Zen has been doing this for quite a while. :-D

The theme description links to the online documentation.

#3

Posted by Gábor Hojtsy on December 7, 2009 at 6:09pm
Status:active» needs review

Ok, I've looked at the existing code, and not at all sure why it uses

<?php
addcslashes($value, "\0..\37\\\"")
?>
for stuff coming from previously quoted strings, (after stripping off existing quotes in _potx_format_quoted_string()) but I've applied this same treatment to the info file strings. Let me know if this works for you. Bytes from \0 to \37 should never appear in .info file strings anyway, theoretically.

Please test and review so we can fix this issue.

AttachmentSizeStatusTest resultOperations
addslashes-info.patch1.12 KBIgnored: Check issue status.NoneNone

#4

Posted by Takafumi on January 23, 2010 at 9:39am
Status:needs review» reviewed & tested by the community

#3 patch works fine and fixed this issue.

#5

Posted by Gábor Hojtsy on May 7, 2010 at 2:38pm
Version:6.x-3.x-dev» 7.x-1.x-dev
Status:reviewed & tested by the community» patch (to be ported)

Committed to D6, to be ported to D7.

#6

Posted by Gábor Hojtsy on May 7, 2010 at 4:27pm
Status:patch (to be ported)» fixed

D7 port.

AttachmentSizeStatusTest resultOperations
addclashes-d7.patch1.13 KBIgnored: Check issue status.NoneNone

#7

Posted by System Message on May 21, 2010 at 4:30pm
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.