There isn't addcslashes to .info stings, is it by design ? (Command line extraction)

example:

#: active_n_rebuild/active_n_rebuild.info:0
msgid "[EN] Table-based multi-column extended theme (for Web developers).<br />Work with PHP5 (PHP4 - with no waranty).<br />Copyright &copy; 2009 <a href="http://lynxlab.net" title="Open Lynxlab project (in a new window)" target="_blank">Lynxlab.net</a>"
msgstr ""
CommentFileSizeAuthor
#6 addclashes-d7.patch1.13 KBgábor hojtsy
#3 addslashes-info.patch1.12 KBgábor hojtsy

Comments

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

Wow, we definitely did not expect people to put HTML into their descriptions. Looks like this needs to be fixed indeed.

johnalbin’s picture

johnalbin
they/他
Primary language English
Location Taipei, Taiwan
commented

Zen has been doing this for quite a while. :-D

The theme description links to the online documentation.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Active » Needs review
StatusFileSize
new addslashes-info.patch1.12 KB

Ok, I've looked at the existing code, and not at all sure why it uses addcslashes($value, "\0..\37\\\"") for stuff coming from previously quoted strings, (after stripping off existing quotes in _potx_format_quoted_string()) but I've applied this same treatment to the info file strings. Let me know if this works for you. Bytes from \0 to \37 should never appear in .info file strings anyway, theoretically.

Please test and review so we can fix this issue.

Takafumi’s picture

Takafumi commented
Status: Needs review » Reviewed & tested by the community

#3 patch works fine and fixed this issue.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Version: 6.x-3.x-dev » 7.x-1.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

Committed to D6, to be ported to D7.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Patch (to be ported) » Fixed
StatusFileSize
new addclashes-d7.patch1.13 KB

D7 port.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.