Closed (fixed)
Project:
Bank Transfer | Ubercart Payment
Version:
6.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
3 Nov 2009 at 07:07 UTC
Updated:
25 Feb 2010 at 09:10 UTC
Jump to comment: Most recent file
Comments
Comment #1
xibun commented@Jhef.Vicedo: thanks for your patch! In general I agree to your changes. But I don't really understand why we should put things like "account number", "bsb", "iban", "swift" and "clearing number" through i18n. I'm sure you have created the patch out of need and therefor can explain what I'm missing here.
Comment #2
matteoraggi commentedI have applyed patchs in past, but with it I'm getting errors, so I wait an updat of this module or that someone will publish the patched file.
Comment #3
xibun commented@matteoraggi: I will patch the module soon. I'm actually waiting to get a more general view on the topic.. so you can help to make it happen :). Why were you looking for this patch? Or in other words: which variables do you hope to be able to translate once you have the patch applied?
Comment #4
matteoraggi commentedWith a quick review of what I need from Europe, I just need:
Payment method title
Payment instructions
IBAN
Bank Account Number
Bank Account Owner
Name of Bank
Address of Bank
SWIFT
IBAN
More info about Europe bank transfers:
http://en.wikipedia.org/wiki/International_Bank_Account_Number
http://en.wikipedia.org/wiki/Single_Euro_Payments_Area
Comment #5
xibun commented@matteoraggi: I'm sitting in Spain :). what I'm wondering is: why would you like to translate IBAN? what does change from one language to the other? same for most of your list... I would like to understand why these items need translation. also see my post #1.
Comment #6
matteoraggi commentedAh sorry I wrote IBAN 2 times, plus I wasn't thinking it as a field to translate, but just a necessary field, sorry, anyway casually it gave me opportunity to check on wikipedia that some countries as japan and few others could need to ransate it:
http://fa.wikipedia.org/wiki/%D8%A7%DB%8C%D8%A8%D8%A7%D9%86
http://ja.wikipedia.org/wiki/IBAN%E3%82%B3%E3%83%BC%E3%83%89
http://he.wikipedia.org/wiki/%D7%9E%D7%A1%D7%A4%D7%A8_%D7%96%D7%94%22%D7%91
It coul be useful for you?
http://drupal.org/project/banking
Comment #7
xibun commentedOk, here an updated patch. My Japanese is limited, but I still have a hunch that they don't translate the IBAN number. So the patch is limited to text variables.
Comment #8
xibun commentedPatch committed to development version. Thanks Jhef.Vicedo & matteoraggi. Will be available tomorrow.
(btw: sorry the patch in #7 was in the wrong direction)
Comment #9
matteoraggi commentedSorry for delay, I don't have got yet time to apply this patch, but I have updatd the new .dev version, I'm going ok in this way? I continue to test in this way your module, right?
Comment #10
xibun commentedthere is no need to change status. I see your message anyway.
yes: the patch is already integrated in the .dev version you found on the project page.
Comment #11
matteoraggi commentedI checked, as first I find th string named:
Bank transfer
/admin/store/settings/payment/edit/methods
and it is just ranslatd in italian, but then from here I see it again in english:
cart/checkout
It look that he go to translate this string for admin panel admin/store/settings/payment/edit/methods but not fo public checkout page.
Instead it look that he get the string from this text that i can'ttranslate instead yet:
Payment method title
Comment #12
ckidowPlease use following t-strings in /cart/checkout/review:
A) "reason for transfer" instead of "subject" and (reserved for e.g. email "subject")
B) "account number" instead of "account" and (because it should be the same like in payment settings)
C) "Order number:" instead of "order number". (because it should be the same like uc_order uses)
Greetings
CKIDOW
Comment #13
xibun commentedthanks for your feedback matteoraggi & CKIDOW. I will look into it as soon as I have a bit of time.
Comment #14
Militopedia commentedHello,
I have the same problem as matteoraggi:
In the configuration page of ubercart I can enter a bank transfer message (e.g. details about when and how to do the bank transfer). If I switch languages, the text is shown correctly in different laguages in the configuration pages.
However, when I go to checkout where I can choose the payment option, only the English text appears when I chose bank transfer (which I guess is loaded using java script).
Strange enough, on the next page that shows the order summary, the translated text is shown (which I guess is printed using a php template).
I tried to include the variable into settings.php, but no change.
Can anybody tell me how I can correct the code so that the translated instructions is shown on the checkout page?
Thanks,
Roger
Comment #15
Jhef.Vicedo commented@xibun: I agree with you (number variables shouldn't be translated). I just included them just in case.
Comment #16
xibun commented@matteoraggi & @Militopedia: I just checked and confirm the same issue: payment method title isn't translated on cart/checkout. did anyone find the solution yet? my feeling is we have to look in ubercart....
Comment #17
xibun commentedin response to post #12 by CKIDOW I committed the following changes today:
- 'Account' -> 'Account number'
- 'Bank' -> 'Banking institution'
- 'Branch' -> 'Branch office'
- 'Subject' -> 'Reason for payment'
Comment #18
xibun commented@matteoraggi & @Militopedia: you can subscribe to the new issue I created about the translation problem of the payment method title -> #711178: Payment method title not translated on cart/checkout page
(@Militopedia: note that the payment method title is only displayed on the checkout page - the string displayed on review page is the payment method name)