I use this module for a community site we are currently working on where users can create own blogs and contribute to others. Everything works splendid but I have recently discovered a bug that can be very problematic when we put the site live.

Sometimes (randomly) when editing other vocabularies than the one Ownterm is associated with, Ownterm's checkbox for the vocabulary is reset which means alot of weird things can happen. Would it be possible to add something to the code that prevents this checkbox from loosing its choice?

Thanks for a great module!

CommentFileSizeAuthor
#4 621738-ownterm-loses-setting.patch948 bytescoltrane

Comments

3dloco’s picture

3dloco commented
Issue tags: +loses settings, +ownterm, +edit vocabulary

Hello,

Also, thanks for this great module too! I can confirm this behavior as well, the "enable ownterm" settings on the taxonomy->edit->vocabulary page gets "unchecked" every time I edit any of the other vocabularies.

Thanks,

KH

coltrane’s picture

coltrane
he/him
commented

This might be because there can be only one (like Highlander) vocab set for ownterm and the bug is that the old one gets unset. Bah, that'd be bad. I haven't looked at the code in awhile. I'll try to get to this soon.

mattiasj’s picture

mattiasj commented

It would be great to in some way force Ownterm to protect its vocabulary. At the moment this is (at least what I have found) the best solution for creating a lightweight multi user blogging system. It really works well so i hope this issue can be resolved!

coltrane’s picture

coltrane
he/him
commented
Status: Active » Needs review
StatusFileSize
new 621738-ownterm-loses-setting.patch948 bytes

Try this patch out, it alters the behavior so the variable is only deleted if the checkbox value is 0 and the vocab we are submitting did have ownterm enabled.

3dloco’s picture

3dloco commented

@coltrane: Thanks your patch works! Now ownterm vocab no longer loses its setting when I update other vocabs.

mattiasj’s picture

mattiasj commented

@coltrane: Thanks alot, this works great. Can it be commited to a new release?

coltrane’s picture

coltrane
he/him
commented
Title: Ownterm looses its vocabulary setting » Ownterm loses its vocabulary setting
Status: Needs review » Reviewed & tested by the community

I'll try and commit soon and get a new release out.

mattiasj’s picture

mattiasj commented

Thanks alot.

coltrane’s picture

coltrane
he/him
commented

I've committed the patch in #4 and made a development release which will soon appear on http://drupal.org/node/575064/release. I expect to make a 1.1 release next week, so if you would please wait to upgrade your production sites till then.

coltrane’s picture

coltrane
he/him
commented
Status: Reviewed & tested by the community » Fixed

Fixed in dev release and forthcoming 1.1 release.

mattiasj’s picture

mattiasj commented

Great job!

Status: Fixed » Closed (fixed)
Issue tags: -loses settings, -ownterm, -edit vocabulary

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +loses settings, +ownterm, +edit vocabulary

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.