Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Great module, Thanks! History graphs are correctly displayed, but on the daily tab only the selection box is shown. Regardless what I choose (and hit show) no graphs are generated! (I'm using Drupal 4.7 and latest cvs version of graphstat, 1.7).
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | graphstat.module.patch | 832 bytes | profix898 |
| #1 | graphstat_0.module | 11.34 KB | DriesK |
Comments
Comment #1
DriesK commentedcan't reproduce, works well on several 4.7 test sites for me.
however, there have been changes to the forms api. I did a quick hack (file attached) just to see what happens. Can you replace it on your server and give it a try?
PS Are you using the official 4.7 distribution? Or some RC? Or a beta version? Or to put it differently: which version of form.inc are you using?
Comment #2
DriesK commentedand just to make sure (and starting with the most obvious): in administer->settings->statistics, 'enable access log' should be set to 'enabled'. Otherwise, the dropdown list shows every date from 01/01/1970 until today, which is obviously not the idea.
Now that I'm thinking of this, this can be considered as a bug. I'll fix it soon.
Comment #3
profix898 commentedI'm using the release version of Drupal 4.7 (updated from RC2) and YES I have access log enabled :)
However the modified graphstat from above works great! Thanks.
Comment #4
profix898 commentedIts not your modification from above ... the module works fine with default (en) language. However switching to another language (german in my case) leads to the reported bug. The error is in line 102 (graphstat.module)
$form['submit'] = array('#type' => 'submit', '#value' => t('Show'));. Label 'Show' was not a t() string, but a few lines laterif ($_POST['op'] == t('Show') ...it is! So switch to a language other than default/english and the two strings do not match and the _POST block is not executed. It can be that simple ... ;) Thanks again.Comment #5
DriesK commentedthanks for spotting that! Patch committed to HEAD and 4.7. Marking this as fixed, I'll open another issue for the date selector bug.
Comment #6
(not verified) commented