Posted by rfay on November 3, 2009 at 3:54pm
| Project: | Amazon Module |
| Version: | 6.x-1.0-beta10 |
| Component: | Code |
| Category: | task |
| Priority: | normal |
| Assigned: | rfay |
| Status: | closed (fixed) |
| Issue tags: | 6.x-1.0 blocker |
Issue Summary
Currently the invalid_asin filter works with 0 or 1, but it should be a boolean selector or at least numeric.
If you're using the invalid_asin filter with beta10, please make sure to select the value as either 0 (for not invalid) or 1 (for invalid)
Comments
#1
#2
Filter works right now.
http://drupal.org/cvs?commit=302414
#3
Automatically closed -- issue fixed for 2 weeks with no activity.
#4
Hi Randy,
sorry for re-opening this issue; for me the invalid_asin filter seems not to work as expected.
In my watchdog logs, I'm getting a lot of "Error retrieving Amazon item ..." messages. To look after them, I built two views (one with relationship to field_asin, and one with relationship to field_legacy_asin. I'm filtering these views by default to something like "(field_asin_asin) Amazon: Invalid ASIN not true", which outputs results.
However, as soon as I change this filter to "true" (now I want the invalid ASINs only, the results become empty, on both views. Either I'm doing something wrong here, or the "Error retrieving Amazon item ..." do not lead to proper records in the database. As I understand it, an ASIN that couldn' retrieved from Amazon should result in setting 'invalid_asin' to '1' (= true).
When looking up the record in my database, I'm getting:
mysql> select * from amazon_item where invalid_asin=1;Empty set (0.01 sec)
If - and only - if I'm looking in the right place (table 'amazon_item', querying the field 'invalid_asin' for values that are equal to "1"), no tems seem to become flagged as 'invalid'. Is this possible?
Thanks & greetings, -asb
#5
OK, I'm going to set this one to fixed, as you have proved that the filter is behaving correctly. We'll have to figure out what the issue is elsewhere.
There can be many reasons that a fetch from Amazon fails, not just invalid ASIN. So we have to figure out what's going on in your case.
Please look at the "detail" section of your watchdog entries (and nearby watchdog entries). If that doesn't immediately sort it out for you (which I doubt, since I'm sure you already have done this) then open a new issue. We can start with studying the ASIN that fails (which I think should be reported). If nothing else works, get me a copy of your database.
Please report whether the failure happens on cron or at some other time as well.
Thanks,
-Randy
#6
Automatically closed -- issue fixed for 2 weeks with no activity.