"Show more" links are hardcoded to apachesolr and apachesolr_search modules. This patch abstracts and automates.

robertDouglass - November 3, 2009 - 16:27
Project:Apache Solr Search Integration
Version:6.x-1.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:patch (to be ported)
Description

This patch makes the jQuery selectors for adding the Show more links to blocks dynamic and ustilizes Drupal.settings and apachesolr_get_js to inject the #id selectors of blocks that may need to have the links. The selectors are more precise than class based selectors, so the jQuery should be faster, too, but I didn't benchmark.

AttachmentSize
dynamic-show-more.patch2.57 KB

#1

robertDouglass - November 3, 2009 - 16:29

Added some code comments to keep the codebase from becoming too hard to follow.

AttachmentSize
dynamic-show-more.patch 2.72 KB

#2

robertDouglass - November 3, 2009 - 16:35
Status:active» fixed

Committed to DRUPAL-6--2

#3

claudiu.cristea - November 6, 2009 - 10:00

Backporting?

#4

robertDouglass - November 6, 2009 - 10:41
Version:6.x-2.x-dev» 6.x-1.x-dev
Status:fixed» patch (to be ported)

Claudiu - you can flag issues you think need backporting by changing the status and coordinating with Peter Wolanin.

#5

claudiu.cristea - November 6, 2009 - 14:47

Yes. That's why I asked... The part of code, subject of this patch, is present only in 6.x-2.x.

We have to figure out if we will backport the entire functionality there... I didn't had time to investigate.... Peter?

#6

robertDouglass - November 19, 2009 - 18:03
Version:6.x-1.x-dev» 6.x-2.x-dev
Status:patch (to be ported)» needs review

Here's a band-aid followup. The CCK facet mapping is such a PITA... that needs to be solved. This patch fixes the problem locally.

AttachmentSize
show-more-cck.patch 1.01 KB

#7

robertDouglass - November 19, 2009 - 18:05
Version:6.x-2.x-dev» 6.x-1.x-dev
Status:needs review» patch (to be ported)

#8

robertDouglass - November 19, 2009 - 18:06

(committed #6 to 6.2)

#9

pwolanin - November 29, 2009 - 14:29

Which part needs to be ported to 6.x-1.x?

#10

robertDouglass - November 30, 2009 - 11:24

Peter, #0, #1, and #6 all got applied.

#11

robertDouglass - November 30, 2009 - 11:25

Sorry. Only #1 and #6 got applied.

 
 

Drupal is a registered trademark of Dries Buytaert.