Download & Extend
Apache Solr Search Integration » Issues

"Show more" links are hardcoded to apachesolr and apachesolr_search modules. This patch abstracts and automates.

Posted by robertDouglass on November 3, 2009 at 4:27pm
Project:Apache Solr Search Integration
Version:6.x-2.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

This patch makes the jQuery selectors for adding the Show more links to blocks dynamic and ustilizes Drupal.settings and apachesolr_get_js to inject the #id selectors of blocks that may need to have the links. The selectors are more precise than class based selectors, so the jQuery should be faster, too, but I didn't benchmark.

AttachmentSizeStatusTest resultOperations
dynamic-show-more.patch2.57 KBIgnored: Check issue status.NoneNone
Login or register to post comments

Comments

#1

Posted by robertDouglass on November 3, 2009 at 4:29pm

Added some code comments to keep the codebase from becoming too hard to follow.

AttachmentSizeStatusTest resultOperations
dynamic-show-more.patch2.72 KBIgnored: Check issue status.NoneNone

#2

Posted by robertDouglass on November 3, 2009 at 4:35pm
Status:active» fixed

Committed to DRUPAL-6--2

#3

Posted by claudiu.cristea on November 6, 2009 at 10:00am

Backporting?

#4

Posted by robertDouglass on November 6, 2009 at 10:41am
Version:6.x-2.x-dev» 6.x-1.x-dev
Status:fixed» patch (to be ported)

Claudiu - you can flag issues you think need backporting by changing the status and coordinating with Peter Wolanin.

#5

Posted by claudiu.cristea on November 6, 2009 at 2:47pm

Yes. That's why I asked... The part of code, subject of this patch, is present only in 6.x-2.x.

We have to figure out if we will backport the entire functionality there... I didn't had time to investigate.... Peter?

#6

Posted by robertDouglass on November 19, 2009 at 6:03pm
Version:6.x-1.x-dev» 6.x-2.x-dev
Status:patch (to be ported)» needs review

Here's a band-aid followup. The CCK facet mapping is such a PITA... that needs to be solved. This patch fixes the problem locally.

AttachmentSizeStatusTest resultOperations
show-more-cck.patch1.01 KBIgnored: Check issue status.NoneNone

#7

Posted by robertDouglass on November 19, 2009 at 6:05pm
Version:6.x-2.x-dev» 6.x-1.x-dev
Status:needs review» patch (to be ported)

#8

Posted by robertDouglass on November 19, 2009 at 6:06pm

(committed #6 to 6.2)

#9

Posted by pwolanin on November 29, 2009 at 2:29pm

Which part needs to be ported to 6.x-1.x?

#10

Posted by robertDouglass on November 30, 2009 at 11:24am

Peter, #0, #1, and #6 all got applied.

#11

Posted by robertDouglass on November 30, 2009 at 11:25am

Sorry. Only #1 and #6 got applied.

#12

Posted by David Lesieur on January 3, 2010 at 2:20am

Marked #609040: "Show more" link not shown on facet blocks provided by other modules as duplicate. Both solutions seem to use the same approach.

#13

Posted by claudiu.cristea on January 21, 2010 at 8:52am

This patch is not applicable to 6.x-1.x-dev nor to 5.x-2.x-dev because is referring to a function - apachesolr_js() - missed in those branches.

Options:

  • Wontfix in 6.x.-1.x-dev, 5.x-2.x-dev
  • Port all the Drupal.settings/apachesolr_js() stuff

Peter?

#14

Posted by pwolanin on February 4, 2010 at 12:26am

Making this functionality more generic is nice to have, but I don't see it as critical. If someone wants to roll the patch, fine - otherwise I think it's not something to focus on now.

#15

Posted by jpmckinney on April 30, 2010 at 5:09am
Version:6.x-1.x-dev» 6.x-2.x-dev
Status:patch (to be ported)» fixed

Not backporting JS. Marking fixed for 6-2.

#16

Posted by System Message on May 14, 2010 at 5:10am
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

nobody click here