CVS edit link for atelier

I am in the process of porting a GPL-based WordPress theme from Themes Boutique called Celadon. Information about the theme including licensing and a demo can be found on their website:

http://www.themesboutique.com/theme/celadon

I was immediately drawn to the elegance and simplicity of this theme and thought it would be a welcome option for Drupal sites, particularly blogs. The conversion, a sub-theme of Genesis, is nearly complete and the theme is working quite well. I would like to make a few more refinements before a issuing a release, which should be completed in a week or two.

Comments

atelier’s picture

Status: Postponed (maintainer needs more info) » Needs review
StatusFileSize
new92.83 KB
new622.59 KB

Attached is the preliminary port of the Celadon theme. This is a sub-theme of Genesis (http://drupal.org/project/genesis). I've also attached a screen shot of the theme in its current state.

avpaderno’s picture

Status: Needs review » Needs work
Issue tags: +Theme review

Remove the original files, and the Komodo IDE project file.

Also, the directories contained in the archive have a permission problem; the permissions set don't allow me to open them, and I need to change them for all the directories, before to be able to review the code.

atelier’s picture

StatusFileSize
new300.28 KB

Attached is an updated tarball.

avpaderno’s picture

Status: Needs work » Needs review
avpaderno’s picture

Status: Needs review » Needs work
  1. ; Information added by drupal.org packaging script on 2009-06-12
    version = "6.x-2.4"
    core = "6.x"
    project = "genesis"
    datestamp = "1244821869"
    

    Those lines should be removed, as they are already added by the packaging script.

  2. The content of template.php is only commented code, which can be removed.
avpaderno’s picture

StatusFileSize
new116.31 KB

Also, the actual theme is quietly different from the one shown in the reported link.

atelier’s picture

Status: Needs work » Needs review
StatusFileSize
new307.4 KB

#5.1 - These lines have been removed.
#5.2 - The code in template.php is there for end user customization so it should not be removed.
#6 - The "Drupal" text can be removed by disabling the display of "Site name" in the theme configuration. I am unable to reproduce the search box differences. This is styled in the CSS. I have tested successfully using the Windows version of FF3, IE7, and Safari 4. Which OS/browser are you using?

Attached is an update less the packaging code referenced in #5.

avpaderno’s picture

I am using the version of Safari 4 for Mac OS X.
It's the same browser I used to check the demo at http://www.themesboutique.com/theme/celadon; if the demo is for this theme, I would have not noticed relevant differences, if not those caused by different settings. Truly, the demo doesn't run on Drupal, and this could explain the differences I found.

atelier’s picture

The theme looks fine to me in Win Safari. I don't have a Mac so I can't test with that. Are there any other issues? What's the next step?

atelier’s picture

Can I get an update on the status of my CVS account? Thank you.

avpaderno’s picture

Status: Needs review » Needs work

I cannot review the code because the directories contained in the archive, once expanded, have custom permissions, and I cannot access them.
I tried with two different applications. The first application creates the directories, to which I don't have permission to access; the second application create an empty directory.

To notice that I have not had any problems with the archive attached to the comment #3.

atelier’s picture

Status: Needs work » Needs review
StatusFileSize
new334.5 KB

Attached is a new version of the project with full privileges.

* Note *
The project has been re-worked as a subtheme of Fusion (http://drupal.org/project/fusion). Please let me know if you need anything else. Thank you for your help.

atelier’s picture

StatusFileSize
new334.5 KB

I just noticed the tarball may have insufficient permissions. Attached is another file.

atelier’s picture

StatusFileSize
new330.59 KB

Attached is a new version of the theme. I've adjusted the default settings and tweaked a few things so that it works much better now after installation. Note that this theme requires the Fusion core theme. Fusion core doesn't need to be enabled, but it does need to be added to the themes folder.

avpaderno’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)
Issue tags: -Theme review

Automatically closed -- issue fixed for 2 weeks with no activity.

avpaderno’s picture

Component: Miscellaneous » new project application
Assigned: Unassigned » avpaderno
Issue summary: View changes
Status: Closed (fixed) » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.