jacksinn [jacksinn]

Remember to change the status, when you upload new code.

1. /*#####################################################
   * JPIIM HELP
   * ####################################################
   */
   

   The comment before a hook implementation usually reports which hook is implemented by the function.

2. 	$items['admin/build/jpiim'] = array(
   		'title' => t("Jpiim settings"),
   		'description' => t("Put your URL to pull from here"),
   		'page callback' => 'drupal_get_form',
   		'page arguments' => array('jpiim_admin'),
   		'access arguments' => array('access administration pages'),
   		'type' => MENU_NORMAL_ITEM,
   	);
   

   Menu titles, and descriptions should not be passed to t() because that is already done by Drupal core code.

3. 		'#title' => t("JPIIM BLOCK 0 Settings"),
   		'#collapsible' => TRUE,
   	);
   	$form['jpiim_settings_0']['jpiim_url_0_desc'] = array(
   		'#type' => 'textfield',
   		'#title' => t("BLOCK DESCRIPTION"),
   

   Titles should use a capital case word as first word, while the other words should be lower case words (with the exception of proper nouns, and acronyms).

4. 		'#title' => t("URL To Pull In"),
   		'#default_value' => variable_get('jpiim_url_0', ''),
   		'#size' => 100,
   		'#description' => t("What URL to pull in"),
   

   The description is not useful, if it repeats what said in the title of the form field.

5. function jpiim_clear_cache_all() {
   	$dir = file_directory_path() . "/jpiim/cache/";
   	$handle = opendir($dir);
   
   	while (($file = readdir($handle)) != false) {
   		@unlink($dir . "/" . $file);
   	}
   
   	closedir($handle);
   	return;
   }
   

   There is a Drupal function that can be used to scan the files contained in a directory.

To do what the module does, there is no need to use the module. It would be enough to create a custom block; doing so, I would not be limited to use 4 blocks, but I would be able to create any blocks I would.

See the Drupal coding standards to understand how a module code should be written. In particular see the suggested formatting.
Some strings are not translated.

There have not been replies from the OP in the past 7 days. I am marking this report as won't fix.