The meta tags are not shown for a page using the pager
giorgio79 - November 3, 2009 - 20:46
| Project: | Nodewords |
| Version: | 6.x-1.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | fixed |
Description
Hi Kiam,
The pager menu seems to have gone missing in my latest version.
Am I the only one?
#1
The settings for the list pages (aka pager) has been moved in the settings page. So far, it is only possible to change the meta tag ROBOTS.
#2
Thanks Kiam.
I just ticked noindex, but I have not seen any meta tags appear with it.
Also, perhaps a little note to users explaining that lists are pagers are important.
Cheers,
G
#3
Did you select ?
Also, that setting is valid only for the list pages, except the first one.
I will change the description given for the form field to make clearer to what it refers to.
#4
I just changed the description of the form field to make clearer what its purpose is.
#5
Hi Kiam,
I just ticked "Repeat stuff on lists..." but still the NOINDEX that I enabled is not appearing.
I checked for
taxonomy/term/123
taxonomy/term/123?page=1
taxonomy/term/123?page=2
As I understand from page=1 onwards, it should have noindex.
#6
That is fine. When that option is selected, the content for the meta tag ROBOTS is the value that is set for that page. The settings for the list pages are used when that option is not enabled.
If you don't see the value for the meta tag ROBOTS when that option is not enabled, and when you are watching the second page of list pages, then something is wrong.
#7
The code executed is the following:
<?php/**
* Set the meta tag content.
*/
function nodewords_basic_robots_prepare(&$tags, $content, $options) {
if ($options['type'] == 'pager') {
$value = variable_get('nodewords_list_robots', array());
}
// ...
}
?>
I would expect the specific meta tag ROBOTS content to be used when a list page (which is not the first page of the list) is shown.
#8
I can reproduce the issue.
When a page with a pager is shown, and the page is not the first page, the setting for the meta tag ROBOTS is not respected, and the meta tag is not shown. That is valid when the option to use the same meta tags for all the pages of the same list is not enabled.
#9
Also the canonical URL meta tag is not shown, for a page using the pager.
In the function detecting the type the page being shown, the first code lines are the following:
<?php
function _nodewords_detect_type_and_ids() {
$arg = arg();
$bool = (
!variable_get('nodewords_list_repeat', FALSE) &&
isset($_REQUEST['page'])
&& intval($_REQUEST['page']) > 0
);
if ($bool) {
return array('pager', array(''));
}
?>
This means that the page is reported to be part of a list, when the option to repeat the same meta tags for all the pages of the same list is not enabled, the variable
$_REQUEST['page']is set, and its value is an integer greater than 0.I don't see why that condition would fail to be verified.
#10
I tried to execute the following code on the page of devel.module that allow to execute PHP code (I accessed that page using an URL like http://sunradio.local/dr61/devel/php?page=2):
<?php$result = _nodewords_detect_type_and_ids();
dsm($result);
?>
The result was as expected; the page has been known to be part of a list.
#11
The code has been changed, and committed in CVS.
Thanks for your report.
#12
Hi Kiam,
Just tested the 11-04 dev release but I still don't see the robots noindex tag.
I can see the keywords and canonical tags output on all pager pages, but no robots noindex. :)
Any ideas? :)
#13
Kiam, I found the issue :)
I had enabled the editing on forms for the robots tag, and that is why it was not showing.
I unticked it, and it immediately started showing :)
Thanks for your patience.
Cheers,
G
#14
I am not sure I understand what you mean. :-)
May you attach a screenshot to show what you unchecked? If you unchecked what I am thinking of, then something is wrong.
#15
It is under
Settings -> Meta Tags To Show on Settings Forms -> Robots
#16
Then something is wrong. If you select a meta tag in that list, then it must appear in the edit forms.
Actually, the fieldset title is not the one you reported, but (see the attached screenshot).
#17
As my last question didn't get an answer, I am assuming all is fine.
I am marking this report as fixed.
#18
Since the confusion over 'Meta tag ROBOTS for lists' exists on this thread, I am posting my question here.
I am a wee bit confused on what the 'Meta tag ROBOTS for lists' actually does?
Say for example if I didn't want Taxonomy Term pages or list pages/pages with pagers from appearing in search engine results, do I just tick the 'No Follow'?
A lot of the my Google search results show Taxonomy Term pages before they show actual nodes/content. I'm trying to fix this.