DX: Start using the "container" form type

I don't understand the question.

I have no idea, why it shouldn't work. Did you flush your caches?

Also, I'd highly prefer a custom #inline => TRUE property that simply replaces the .form-wrapper CSS class with .container-inline when being set.

Sorry, but I need to clean some tags here.

+++ modules/system/system.module	3 Nov 2009 21:43:52 -0000
@@ -2545,7 +2545,10 @@
+  $form['actions'] = array(
+    '#type' => 'container',
+    '#attributes' => array('class' => array('container-inline')),
+  );

I'd additionally would like to see a class

'form-actions' here.

This review is powered by Dreditor.

+++ includes/form.inc	3 Nov 2009 21:43:51 -0000
@@ -2193,7 +2193,10 @@
 function form_process_container($element, &$form_state) {
-  $element['#id'] = drupal_html_id(implode('-', $element['#parents']) . '-wrapper');
+  if (!isset($element['#id'])) {
+    $element['#id'] = drupal_html_id(implode('-', $element['#parents']) . '-wrapper');
+  }
+  $elements['#attributes']['class'][] = 'form-wrapper';
   return $element;

@@ -2211,7 +2213,12 @@
 function theme_container($variables) {
   $element = $variables['element'];
-  return '<div class="form-wrapper" id="' . $element['#id'] . '">' . $element['#children'] . '</div>';
+  // Inject the element's ID into the attributes, if provided.
+  $attributes = isset($element['#attributes']) ? $element['#attributes'] : array();
+  if (isset($element['#id'])) {
+    $attributes['id'] = $element['#id'];
+  }
+  return '<div' . drupal_attributes($attributes) . '>' . $element['#children'] . '</div>';

Note that I already did those changes in another issue elsewhere, which was already committed.

Would be totally awesome to get the other changes of this patch in!

This review is powered by Dreditor.

Thanks!

#482816: Make a consistent wrapper around submit buttons was committed so setting this back to review

The patch is simple and looks good.

I found a lot more.
Gonna repatch this tomorrow with everything I find!

I looked for other opportunities to use the "container" type, but it looks like #676800-139: Fieldsets break design badly already did that (there are maybe one or two places in each of taxonomy.module, poll.module, and node.module where the "container" type could be used). However, even if we can replace these with the "container" type and not impact functionality, we would still have to test for browser compatibility. So, marking duplicate.