Download & Extend
Advanced Forum » Issues

image-replace spans appearing links

Posted by fred0 on November 4, 2009 at 12:47am
Project:Advanced Forum
Version:6.x-2.x-dev
Component:Styles
Category:support request
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

I'm seeing <span class="image-replace"></span> appearing in the page display text of the node links for reply/edit/delete in forum topics. It is generated by line 78 of advanced_forum_preprocess_node.inc.
Also, the Post Reply text is not completely covered by the image (at the top left).
See attached nodelinks.png for example.

In the topic display, I also see the <span class="image-replace"></span> appear for the New topic link. This one is line 387 of core-overrides.inc
See topiclist.png for example.

AttachmentSize
nodelinks.png34.69 KB
topiclist.png58.7 KB
Login or register to post comments

Comments

#1

Posted by Michelle on December 12, 2009 at 2:58pm
Category:bug report» support request
Status:active» postponed (maintainer needs more info)

I have no idea what might cause that. Normally browsers will interpret the HTML, not just display it. Have you found anything out?

Michelle

#2

Posted by fred0 on December 18, 2009 at 12:52am

I afraid I didn't. Ended up dropping AF from my build.

#3

Posted by Michelle on December 18, 2009 at 3:54am
Status:postponed (maintainer needs more info)» closed (fixed)

Ah, sorry to hear that. If it becomes an issue again, feel free to re-open. Though I don't know that I have any more to tell you...

Michelle

#4

Posted by chucky-x on September 7, 2010 at 1:03pm
Priority:normal» critical
Status:closed (fixed)» active

Hi Michelle, I have the same problem and I can not solve it. The problem is that it becomes to &lt;span class="image-replace"&gt;&lt;/span&gt; within the text node. I would like to html_entity_decode this string but I do not know where to do it. Perhaps you can help to fix this issue.

Edit: After testing to decode the html entities back it seems to me that the convertion happens after calling $variables['forum_links'] = theme('links', $variables['links'], array('class' => 'forum-links')); in advanced_forum_preprocess_forums.inc

#5

Posted by chucky-x on September 8, 2010 at 7:28am

Found a solution: Remove all <span class="image-replace"></span> from includes/mark-read.inc : line 19, 25 and from advanced_forum.module : line 423, 727, 815, 829, 850 and set up your css style to show button over text like here: (I am not experienced in Drupal or CSS, so it can be wrong)

.en .forum-links .mark-read span
{
display: block;
text-indent: -9999px;
}

.en .forum-links .mark-read
{
  display: block;
  background: transparent url(images/en/mark-read.png) no-repeat;
}

#6

Posted by Michelle on October 4, 2010 at 9:48pm
Priority:critical» normal
Status:active» fixed

Looks like you found something that works for you.

Michelle

#7

Posted by System Message on October 18, 2010 at 9:50pm
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

nobody click here