Contextual links UI elements are not a library

sun - November 4, 2009 - 03:39
Project:Drupal
Version:7.x-dev
Component:system.module
Category:bug report
Priority:normal
Assigned:sun
Status:closed
Issue tags:Contextual links
Description

A module that wants to provide a different behavior and representation for contextual links will have a performance impact, because the JS/CSS cannot be altered once.

Just make it a library and the issue is resolved.

I already had this in mind when doing the original implementation, but somehow, I forgot.

AttachmentSizeStatusTest resultOperations
drupal.contextual-links-library.patch1.2 KBIdlePassed: 14679 passes, 0 fails, 0 exceptionsView details

#1

Rob Loach - November 5, 2009 - 20:38
Status:needs review» reviewed & tested by the community

Simple and elegant. Like sun said, having this allows contrib modules to change how the contextual links look/work.

#2

sun - November 7, 2009 - 16:32

I want this to get in before doing #626286: Make contextual links a module

#3

Bojhan - November 8, 2009 - 00:59

How can you forget? Jeez :'D

#4

webchick - November 8, 2009 - 10:29
Status:reviewed & tested by the community» fixed

Makes sense to me.

Committed to HEAD.

#5

System Message - November 22, 2009 - 10:30
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.