Download & Extend
Page Title » Issues

PostgreSQL compatibility

Posted by gatoth on November 4, 2009 at 8:21am
Project:Page Title
Version:6.x-2.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

In PostgreSQL, queries strings have to be enclosed in apostrophes ('), quotation mark (") does not work. Please fix it.

Thanx,
Gabor

Login or register to post comments

Comments

#1

Posted by valthebald on December 30, 2009 at 12:34pm
Status:needs work» needs review

People, please!
The world is not stuck to mysql :)
Please find attached patch against 6.x-2.3

AttachmentSize
page_title_pg.patch 3.29 KB

#2

Posted by Andy Dorman on December 30, 2009 at 11:52pm

FWIW, I just applied the patch to a new install using 6.x-2.3 and it works great with PgSQL 8.4

#3

Posted by nicholasThompson on February 9, 2010 at 9:58am
Version:6.x-2.2» 6.x-2.x-dev
Status:needs review» patch (to be ported)

Thanks guys - I've never used PostgreSQL so have no experience (or system) for testing this.

I have applied a similar fix to that in your patch (I actually just switched the single and double quotes around... Works on MySQL and looks like it achieves the same thing as your patch).

Marking as TBP...

#4

Posted by beasley on February 15, 2010 at 3:20pm

Just tried the dev version on PostgreSQL 8.1.19 and it works fine.

#5

Posted by nicholasThompson on February 15, 2010 at 3:27pm

Thanks Beasley :)

#6

Posted by beasley on February 15, 2010 at 11:07pm

No problem. Thanks for the really useful module!

#7

Posted by John Franklin on September 4, 2010 at 11:56am

This patch has been sitting around for a full eight months. Can we please get this into a release soon?

#8

Posted by davidwhthomas on December 15, 2010 at 3:29am

This module uses invalid SQL syntax which breaks on postgres.

Basically, quote marks are around the wrong way

db_query('DELETE FROM {page_title} WHERE type = "term" AND id = %d', $edit['tid']);

should be
db_query("DELETE FROM {page_title} WHERE type = 'term' AND id = %d", $edit['tid']);

In all cases.

In then works fine on mysql and postgres.

Without this, postgres users see constant error messages on screen.

Otherwise, a useful module, thanks.

#9

Posted by onewomanbiz on February 25, 2011 at 11:13pm

Where / how have you used this patch?

I tried the patch through the PGSQL interface and came up with a pgsql error in the code.

I tried looking at database.pgsql.inc line 139, and dreamweaver'd the whole file looking for erroneous " to change them manually to ', everything is already apostrophed.

warning: pg_query(): Query failed: ERROR: column "node" does not exist in /includes/database.pgsql.inc on line 139.

warning: pg_query(): Query failed: ERROR: column "user" does not exist in /includes/database.pgsql.inc on line 139.

warning: pg_query(): Query failed: ERROR: column "timezone_id" of relation "users" does not exist in /includes/database.pgsql.inc on line 139

I get error node column doesn't exist, time_zone column not found...all basically the same error in line 139 database.pgsql.inc.

Any suggestions?

#10

Posted by nicholasThompson on June 28, 2011 at 3:12pm
Status:patch (to be ported)» fixed

This is fixed in both D6 and D7 - as far as I know.

#11

Posted by valthebald on June 29, 2011 at 9:55am

confirm - D6 version works with postgres 8.4

#12

Posted by nicholasThompson on June 29, 2011 at 3:53pm

thank you valthebald :)

#13

Posted by System Message on July 13, 2011 at 4:02pm
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

nobody click here