PostgreSQL compatibility

People, please!
The world is not stuck to mysql :)
Please find attached patch against 6.x-2.3

FWIW, I just applied the patch to a new install using 6.x-2.3 and it works great with PgSQL 8.4

Thanks guys - I've never used PostgreSQL so have no experience (or system) for testing this.

I have applied a similar fix to that in your patch (I actually just switched the single and double quotes around... Works on MySQL and looks like it achieves the same thing as your patch).

Marking as TBP...

Just tried the dev version on PostgreSQL 8.1.19 and it works fine.

Thanks Beasley :)

No problem. Thanks for the really useful module!

This patch has been sitting around for a full eight months. Can we please get this into a release soon?

This module uses invalid SQL syntax which breaks on postgres.

Basically, quote marks are around the wrong way

db_query('DELETE FROM {page_title} WHERE type = "term" AND id = %d', $edit['tid']);

should be

db_query("DELETE FROM {page_title} WHERE type = 'term' AND id = %d", $edit['tid']);

In all cases.

In then works fine on mysql and postgres.

Without this, postgres users see constant error messages on screen.

Otherwise, a useful module, thanks.

Where / how have you used this patch?

I tried the patch through the PGSQL interface and came up with a pgsql error in the code.

I tried looking at database.pgsql.inc line 139, and dreamweaver'd the whole file looking for erroneous " to change them manually to ', everything is already apostrophed.

warning: pg_query(): Query failed: ERROR: column "node" does not exist in /includes/database.pgsql.inc on line 139.

warning: pg_query(): Query failed: ERROR: column "user" does not exist in /includes/database.pgsql.inc on line 139.

warning: pg_query(): Query failed: ERROR: column "timezone_id" of relation "users" does not exist in /includes/database.pgsql.inc on line 139

I get error node column doesn't exist, time_zone column not found...all basically the same error in line 139 database.pgsql.inc.

Any suggestions?

This is fixed in both D6 and D7 - as far as I know.

confirm - D6 version works with postgres 8.4

thank you valthebald :)