Messing with the upload function (Title required error; Interface woes)

I am trying to recreate this behaviour. After you first get the "title required" message did you hit the save button or the "Submit Images" button? The latter seems to create some advanced weirdness (see below). ;)

BUT: Giving a title and hitting save never fails on my site. Any additional infos about your workflow and settings so that we can recreate the behaviour?

@Maintainers

There is definitly something weird going on. Do the following:

1. Click on "Upload Images" and submit an image.

2. On the next screen leave the title field empty and hit "Save". This correctly throws a "Title required" error.

The problem is that now the screen is some kind of mixture of the interface of step 1 and step 2. Therefore you have an "Submit Images" button and a "Save" button. Hitting the former doesn't upload the image but the filesize seems to be discounted against the user's limit.

To increase the mess leave the title field empty and hit "Submit Images" again. ;)

The problem is that now the screen is some kind of mixture of the interface of step 1 and step 2. Therefore you have an "Submit Images" button and a "Save" button. Hitting the former doesn't upload the image but the filesize seems to be discounted against the user's limit.

I haven't looked at the latest dev yet about the 2 buttons..

But just using the 'Submit Images' button would upload the images to the directory and count the user totals and total file size, even if the upload failed or was refused due to limits.

partly related to issue reported October 10, 2009 for the dev version:
#601186: Image total count not being flushed on failed uploads

I suppose the upload with submit images may have to be done to a tmp directory untill the save is used to actually add the image info to the gallery and the database..
but, (this user is a dummy) and I have no patch to do that.

EDIT: I just installed the latest dev Nov 5th and I don't see two buttons..? just submit images on the upload and manage page ... and save on the sort and manage images page

Did you try to save with an empty title field?

lol... Now i seee what your talking about
submit images, and save.

If you hit 'submit images' a second time after the you get the two buttons:
'submit images', 'save' and another 'save'

the second time you try to 'submit images':
warning: Invalid argument supplied for foreach() in C:\wamp\www\Drupal6\sites\all\modules\node_gallery\node_gallery.pages.inc on line 194.

I had to edit this post.. got confused which buttons I was clicking

it looks like there needs to be a default title 'on click' if someone tries to do this.

People in generally shouldn't be leaving the title field blank so I am not going to prioritize this. What I should probably do is have a check on save that if the title field is empty to default it to the image filename. Again, this is not our biggest concern.

Of course, I'll commit any patch provided!

Just for kicks I tried again and this still exists. Perhaps something we should have in mind for NG3 to prevent there.

Going to bump this up to NG3.

I don't think this is an issue in NG3. The only thing we could do is to add the title automatically to the image filename on hook_node_form_submit()?

Yeah, it isn't a bug right now in NG3, and if it does happen later down the road due to swfupload or manage images tab we can open a new issue. Moving to a won't fix for NG2.