Make the $results array that comes back from a search more useful.

Posted by robertDouglass on November 4, 2009 at 11:27am

Issue Summary

In particular I used modify_query to add a field to the $params['fl'] and was disappointed that the field wasn't automatically available to me in the search results. It was, in fact, available, but only through the badly named 'node' element of the array which contained the Apache_Solr_Document. I could have used the $result['node']->getField('blah'); method but imo this assumes too much knowledge of the phpclient library.

To make it easier to deal with this patch does two things.

1. renames 'node' to 'document'. Note that this creates some mismatch between the array and the theme layer. If it causes problems we have to address the theme layer.

2. iterates over the Apache_Solr_Document and makes an array of its fields called $result['fields'] for easy access.

Attachment	Size	Status	Test result	Operations
results.patch	1 KB	Ignored: Check issue status.	None	None

Comments

#1

Posted by robertDouglass on November 4, 2009 at 11:38am

Here's a version without renaming node->document. A little less disruptive.

Attachment	Size	Status	Test result	Operations
results.patch	879 bytes	Ignored: Check issue status.	None	None

#2

Posted by robertDouglass on November 4, 2009 at 12:31pm

Version:

6.x-2.x-dev

» 6.x-1.x-dev

Committed to DRUPAL-6--2. Marking to be ported.

#3

Posted by robertDouglass on November 6, 2009 at 10:52am

Status:

needs review

» patch (to be ported)

#4

Posted by claudiu.cristea on November 6, 2009 at 3:38pm

Version:

6.x-1.x-dev

» 5.x-2.x-dev

Here's a patch for 5.x-2.x-dev.

Note that I've also moved the comment count generation ($extra[] = format_plural($doc->comment_count, '1 comment', '@count comments');) above drupal_alter('apachesolr_search_result', $doc); (as is in 6.x-2.x-dev) so modules can alter also that value. I think this should also be fixed in 6.x-1.x-dev.