The block settings button that shows up when hovering over some block only shows up in Webkit based browsers.

The attached patch changes the approach to using a .hover class instead of relying on :hover pseudo class.

Tested in IE6, IE7 and Firefox 3 and Safari 4.

CommentFileSizeAuthor
block-edit.patch1006 bytesrecidive

Comments

jeremycaldwell’s picture

jeremycaldwell commented
Assigned: Unassigned » sociotech

Thanks for the suggestions recidive. I'll review this and I'm pretty sure it will go in the Fusion Core's next release.

sociotech’s picture

sociotech commented
Status: Needs review » Closed (won't fix)

recidive, we're not seeing any problems with the block edit links in ie7 or firefox. Are you sure that you're not seeing the links while logged in as an administrator in those browsers?

It's true that the links don't show in ie6, but the number of people administering a site with ie6 should be quite small, and even then, they can still edit the blocks through the normal admin interface.

We work hard to ensure ie6 compatibility where it counts, but adding ie6 compatibility where it's not really needed results in extra work with little payoff and presents more opportunities for bugs to be introduced.

I'd be happy to work with you to find out why the block edit links aren't working for you in other browsers, but we won't be fixing the edit links for ie6.

Thanks for your feedback.

recidive’s picture

recidive commented
Status: Closed (won't fix) » Needs review

Ok, for some reason I can't make this work in my theme.

I'm not overriding block.tpl.php and it occurs even when I disable all css I added. It only works in Safari.

I see the markup for the edit buttons is there, but the :hover don't make them show up.

I still think it's better to have JavaScript handle this, to make it's stable. There are no drawbacks in this approach.

Moving issue back to 'needs review'.

recidive’s picture

recidive commented

Also to add to this, views uses a similar approach for it's admin links.

Patch still applies.

sociotech’s picture

sociotech commented

recidive,

Could you provide some more information about your issue?

1. Do the edit links work in Safari with a freshly installed unmodified version of both Fusion and Acquia Prosper?

2. Are you running any kind of ad blocking plugins on your browsers?

3. Which OSs are you running the various browsers on?

4. Do you get the same results using IE8 and Firefox 3.5?

5. In your original post you mentioned that "some" blocks only show up in Safari. Does that mean that some blocks do show up in Firefox? If so, which blocks do and do not show up in Firefox?

6. Do you get the same results when accessing your site with your theme on a different computer?

7. Could you provide a screenshot of your theme on Firefox for reference?

Thanks.

codycraven’s picture

codycraven commented
Version: 6.x-1.x-dev » 6.x-1.0-beta3
Status: Needs review » Postponed (maintainer needs more info)

I can confirm that the block settings button is fully functional for Firefox 3.5.x, IE 8, and Safari (web-kit based browsers) in beta3.

sociotech’s picture

sociotech commented
Status: Postponed (maintainer needs more info) » Closed (won't fix)

With no additional input and no reports of this issue from any other user, I'm going to consider this a won't fix because there's nothing to fix.