drush_make_updatexml does not catch when release history xml was not found because release history is not NULL

as an an example when one has a make file like

core = 6.x
projects[] = content

then release_history is

object(SimpleXMLElement)#2 (1) {
  [0]=>
  string(65) "No release history was found for the requested project (content)."
}

as the call to load the xml succeeded but there is no project "content"
I will post a simple patch that just checks for the existence of $release_history->name instead of release_history, but maybe these should be different checks with different errors?

also the for each in the same function is not protected so I am thinking there needs to be a check for $release_history->terms->term as well

Comments

e2thex’s picture

StatusFileSize
new802 bytes

Attach is a patch to check release_history->name instead of release_history

e2thex’s picture

StatusFileSize
new802 bytes

sorry the check needs to be for title not name. fixed in attached patch

e2thex’s picture

StatusFileSize
new803 bytes

Not to sure sure footed today but this one is right

dmitrig01’s picture

Status: Active » Fixed

Committed, thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.