drush_make_updatexml does not catch when release history xml was not found because release history is not NULL
as an an example when one has a make file like
core = 6.x
projects[] = content
then release_history is
object(SimpleXMLElement)#2 (1) {
[0]=>
string(65) "No release history was found for the requested project (content)."
}
as the call to load the xml succeeded but there is no project "content"
I will post a simple patch that just checks for the existence of $release_history->name instead of release_history, but maybe these should be different checks with different errors?
also the for each in the same function is not protected so I am thinking there needs to be a check for $release_history->terms->term as well
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | drush_make-623242.patch | 803 bytes | e2thex |
| #2 | drush_make-623242.patch | 802 bytes | e2thex |
| #1 | drush_make-623242.patch | 802 bytes | e2thex |
Comments
Comment #1
e2thex commentedAttach is a patch to check release_history->name instead of release_history
Comment #2
e2thex commentedsorry the check needs to be for title not name. fixed in attached patch
Comment #3
e2thex commentedNot to sure sure footed today but this one is right
Comment #4
dmitrig01 commentedCommitted, thanks!