Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.module_invoke is not used. Instead, the function call is constructed from an array of modules just installed.
Comment added to clarify.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | rdf-use_modules_invoke-623346-4.patch | 1.03 KB | linclark |
| #1 | drupal.rdf_modules_installed.patch | 1.41 KB | linclark |
| drupal.comment_rdf_modules_installed.patch | 376 bytes | linclark |
Comments
Comment #1
Anonymous (not verified) commentedThe above patch is now unnecessary, rdf_modules_installed was revised to use module_invoke
Comment #2
Anonymous (not verified) commentedComment #3
Anonymous (not verified) commentedComment #4
Anonymous (not verified) commentedThis has been rerolled for minor clean up and is ready for review.
Comment #5
sunSorry, I do not see a difference here. Since we do not pass further arguments to the implementations, http://api.drupal.org/api/function/module_invoke/7 does not make any difference.
Comment #6
Anonymous (not verified) commentedI suggested this change because I thought it would be good to use Drupal's built in function to get the return values of hook implementations. Other core modules such as Block and Filter use module_invoke this way.
It seems to me that using module_invoke would be more standard and less hard coded. Field is the only other core module (afaik) that invokes hooks by building the function name where it could use module_invoke instead.
Comment #7
catchI don't think we should use module_invoke() here, it's an additional layer of redirection, and it includes checking for whether the hook implementation exists, which we already know in this case. Won't fixing this one again.