Download & Extend

Link to provider does not work with full view of image

Project:Embedded Media Field
Version:6.x-1.17
Component:Embedded Image Field
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

In my CCK image_url field, the "link to provider" in full node view is not working when I updated the emfield. I am not exactly sure since when its not working, but it used to work I guess 3 updated ago. Any help will be much appreciated.

Comments

#1

Version:6.x-1.15» 6.x-1.17

Yes, there is definitely something wrong.
For me it looks like 'Image Preview Settings' is overwriting 'Full size display settings' and 'Thumbnail'.
It is not possible to set thumbnail to be linked to content and full size image to provider at the moment, you can only have both linked to content or both linked to provider.

#2

Category:support request» bug report

It's definitely a bug.

#3

Status:active» needs review

The problem is in emimage.theme.inc. It looks like a sloppy copy/paste job. The same line that is appropriate for theming preview links is used for full and thumbnail links as well.

$link = isset($options['preview_link']) ? $options['preview_link'] : $field['widget']['preview_link'];

It's pretty straightforward to fix. Just change the word 'preview' to 'full' or 'thumbnail' in each place. Patch attached.

AttachmentSize
emimage-links.patch 1.1 KB

#4

Hey gilgabar

Your patch is giving "patch unexpectedly ends in middle of line" error because it's missing a return character at end of file.

After adding that return character, the patch worked and it solved the issue for me.

#5

Status:needs review» fixed

fixed. thanks @gilgabar.

#6

Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.