Download & Extend

Popups eternal loading screen and cancel link doesen't work - the bug fix

Project:Flag Friend
Version:6.x-1.0-rc2
Component:User interface
Category:support request
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

Hey,

I'm running 1x branch of flag and latest branch of flag friend. This module looks extremely useful and I'm really looking forward to implementing it, but there are a few problems.

When creating the flag link,

<?php
print flag_create_link('friend', $uid);
?>
, the link appears just fine. When I click it, the modal pops up (I have popup api installed and running), I fill out a friend message, confirming I want to be friends with them, and then press submit - but the loading screen (with the circular loading gif) goes on forever, unless I press escape or click somewhere in the page. This stops the loading screen from appearing, but no links appear changed like the javascript toggle in the other flags. If I reload the page, the link does change - but only when I reload the page. This unfortunately is a deal breaker for the use of the module.

Also, when I have requested a user to be my friend and I wish to cancel the request, the request doesen't go through at all, even if I reload the page. I have tried to request and cancel multiple times, and the cancel functionality does not work whatsoever.

I'm really trying to get this module up and working as soon as possible as I'd much rather use flag friend than user relationships.

If someone could get back to me shortly it would really be appreciated!

Thanks!

Comments

#1

I'm sorry. The version I had this problem with was rc-1, although I just loaded on rc2 and the problem still persists. I'm happy to produce screenshots and a detailed bug report and help out any way I can.

Thanks!

#2

What version of Popups API are you using?

#3

Hey thanks for getting back to me so quick!

I'm using Version 6.x-1.3.

I am also able and willing to try the latest alpha-5 if you think that would help.

Thanks so much!

#4

I tried to load on the latest alpha-5 branch and it WSOD'd me, so I don't think thats a viable option. What other information could I provide that could help narrow down the problem? It seems to have something to do with the ajax refresh, it doesen't seem to be submitting properly - as thats where it's hanging. Submit is the most likely issue.

I'm not half-bad at troubleshooting issues so I'm down to help in any way possible.

Thanks!

#5

If you look at the support for Popups within the flag_friend.module, you'll see that I'm utilizing the 'afterSubmit' functionality which points to a function that is included within flag_friend.popups.js. The functionality within there is developed on the 2.x branch of popups, utilizing the Popups objects, namely, Popups.message(); This function did not exists before popups 2.x and will fail on any lower version.

If the latest popups does not work for you, I would suggest finding a way to replicate this functionality within popups 1.3. I would happily include a patch that did something like, check to see if the Popups object exists, if so use it, if not, use a backwards compatible version. You can check through previous version of the flag_friend module to see if I have code there that supported 1.3, but I don't think I did.

Or you could try to figure out why your site is WSOD'ing on popups 2.x

Best of luck!

#6

Problem solved -

Flag was corrupted somehow somewhere, uninstalled the module and reinstalled it, everything works fine.

Popups problem is caused by a conflict with google analyitics module, see popups issue queue. http://drupal.org/node/414812

#7

Status:active» fixed

#8

Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

#9

Just for the record, I was seeing the same issue, which was fixed after switching to the 2.x branch of popups api module.

#10

Title:Popups eternal loading screen and cancel link doesen't work» Popups eternal loading screen and cancel link doesen't work - the bug fix

The problem is not fixed in the latest dev release flag_friend 6.x-2.x-dev !!!

This is the bug in file flag_friend.popups.js, line 19:

The bug:

Popups.message('Flag friend', msg);

The bug fix:

Drupal.popups.message('Flag friend', msg);

Please insert this in your code.

nobody click here