currently log_clear & dblog_clear duplicates functionality

dblog_clear is just a rewrite of log_clear to additionally support dblog_filters (which relies on dblog_ext)

if dblog_ext is not used, then dblog_clear behaves exactly the same as log_clear

if any sub-module of dblog_filters is used then log_clear won't behave properly (it doesn't supports dblog_ext),
which is the reason for dblog_clear to exists

these two module should be merged

I named dblog_clear after log_clear, but using the more clear prefix for the dblog_* suit

Comments

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented
Status: Active » Postponed (maintainer needs more info)

Actually, I think we just need properly document dblog_ext for the project page, including that DC and LC are mutually exclusive. I do have a site where I use LC, but not any of the dblog_ext functions. Also LC is available on D5, so it would be nice to be forward-compatible.

arhak’s picture

arhak commented

dblog_clear doesn't requires dblog_ext
precisely it is a rewrite of log_clear

I renamed it to dblog_* for consistency with the other dblog modules.
please, consider it a whole proposed patch for current log_clear
(the only extra code would be supporting dblog_ext in case it is detected)

if dblog_ext is not used, then dblog_clear behaves exactly the same as log_clear

the only reason it depends on dblog_common is for using the auxiliary function dblog_common_format_minutes (the dblog_common module was intended just to gather auxiliary function, like human-readable format of minutes)

PS: for 5.x the proposed changes for log_clear would be some CSS changes (for consistency with core) and a user_access check to enable the clear button (which should be handled on separated issues, but those would be backport of this one if DC & LC get merged)

if #582622: provide hook for dblog_filters gets committed for 7.x dblog_clear would be the upgrade path for log_clear anyway

arhak’s picture

arhak commented
Status: Postponed (maintainer needs more info) » Needs review

also, dblog_ext/dblog_filters might be backported to 5.x, but, since D7 is already there..

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented

The project page already lists 5.x as frozen.

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented
Status: Needs review » Fixed

I removed log_clear from the package.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.