Posted by arhak on November 4, 2009 at 11:18pm
| Project: | Util |
| Version: | 6.x-3.x-dev |
| Component: | Dblog_extension |
| Category: | task |
| Priority: | normal |
| Assigned: | arhak |
| Status: | active |
Issue Summary
I will use this thread as a centralized TODO list of pending fixes to dblog_ext/dblog_filters suit
PS: please don't use "reply" on previous comments to keep them editable on time
Comments
#1
dblog_clear:
dblog_time_filters:
dblog_host_filter:
dblog_user_filter:
finally
PS: almost all this issues have been pointed out by NancyDru, thanks a lot for your time to review these modules
#2
all the above issues with available patches will be bundled/altogether at #642200: review dblog_ext/dblog_filters updates
#3
One little thing that I would find helpful is to show the current date/time on the filter page so I can see what's recent in the log.
#4
@#3 do you mean showing the current date/time at
admin/reports/dblog?what if I don't have any date/time filter enabled?
what when the page gets old and the time gets outdated? a JS timer?
recent/aged filters are based on "within/beyond the last X minutes", what reference would make having the current time there?
a website could have an administrative tool for showing current time, even with JS updating it every minute, or even it might have a site-wide clock
could you extend on the exactly feature you would like?
#5
Just simply the current time when the page is generated; fancy updating is not important. It doesn't matter if a date/time filter is present.
Something like the attached (who needs sleep anyway).
#6
BTW, rather than sleeping, I also did this.
#7
#5 & #6 are in the scope of
dblog's enhancements, but not in the scope ofdblog_filtersparticularly #6 has a performance impact on a
hook log_filtersthose features might be useful, but I think they should be in a
form_alterinsteadthey could be even in another sub-mod
dblog_enhancetotally independent fromdblog_ext/dblog_filtersI might give them a try in the form of
form_alterdo you agree with me on this?
#8
I just did them where it was convenient last night. As for the time patch, I have no issue with where it is.
I agree that the count patch could be far better somewhere else and done in a better way, such as a core patch to the original query. If you have time to create a core patch to do that, feel free; I do not and will forget by the time I do. You can take full credit for it.
If you would prefer these done differently and have the time, please go ahead.