fix empty username for Anonymous user
arhak - November 4, 2009 - 23:44
| Project: | Utility |
| Version: | 6.x-3.x-dev |
| Component: | Dblog_extension |
| Category: | bug report |
| Priority: | minor |
| Assigned: | arhak |
| Status: | needs review |
| Issue tags: | Quick fix |
Description
first username option have no text while it should be "- None -"
keep every dblog_filter consistent, having select instead of autocomplete make dblog_user_filter require a "- None -" option, which is currently there, but has no text
#1
I misinterpreted this bug, actually the empty text belongs to Anonymous user
(
$row->namedoesn't returns any name)this will be fixed altogether handling this filter by
u.uidinstead ofu.name, since it is no longer an autocompletion but a which might have duplicated names/realnames#2
Note: if this gets committed first then a re-roll would be required for #642164: filter by u.uid instead of u.name and vice versa.
#3
bug fix: use double equals (instead of three) to compare
$row->uid == 0