first username option have no text while it should be "- None -"

keep every dblog_filter consistent, having select instead of autocomplete make dblog_user_filter require a "- None -" option, which is currently there, but has no text

Comments

arhak’s picture

Title: first username option have no text while it should be "- None -" » first username option have no text for Anonymous user
Category: task » bug

I misinterpreted this bug, actually the empty text belongs to Anonymous user
($row->name doesn't returns any name)
this will be fixed altogether handling this filter by u.uid instead of u.name, since it is no longer an autocompletion but a
which might have duplicated names/realnames

arhak’s picture

Title: first username option have no text for Anonymous user » fix empty username for Anonymous user
Status: Active » Needs review
StatusFileSize
new840 bytes

Note: if this gets committed first then a re-roll would be required for #642164: filter by u.uid instead of u.name and vice versa.

arhak’s picture

bug fix: use double equals (instead of three) to compare $row->uid == 0

nancydru’s picture

Status: Needs review » Fixed

Committed.

Status: Fixed » Closed (fixed)
Issue tags: -Quick fix

Automatically closed -- issue fixed for 2 weeks with no activity.