Download & Extend

fix empty username for Anonymous user

Project:Util
Version:6.x-3.x-dev
Component:Dblog_extension
Category:bug report
Priority:minor
Assigned:arhak
Status:closed (fixed)
Issue tags:Quick fix

Issue Summary

first username option have no text while it should be "- None -"

keep every dblog_filter consistent, having select instead of autocomplete make dblog_user_filter require a "- None -" option, which is currently there, but has no text

Comments

#1

Title:first username option have no text while it should be "- None -"» first username option have no text for Anonymous user
Category:task» bug report

I misinterpreted this bug, actually the empty text belongs to Anonymous user
($row->name doesn't returns any name)
this will be fixed altogether handling this filter by u.uid instead of u.name, since it is no longer an autocompletion but a which might have duplicated names/realnames

#2

Title:first username option have no text for Anonymous user» fix empty username for Anonymous user
Status:active» needs review

Note: if this gets committed first then a re-roll would be required for #642164: filter by u.uid instead of u.name and vice versa.

AttachmentSize
2009-11-24_fix_empty_username_for_Anonymous.patch 840 bytes

#3

bug fix: use double equals (instead of three) to compare $row->uid == 0

AttachmentSize
2009-11-25_fix_empty_username_for_Anonymous.patch 839 bytes

#4

Status:needs review» fixed

Committed.

#5

Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

nobody click here