I missed escaping commas & quotes on nodeapi presave
which also requires unescaping before displaying

the attached patch works for every previous version
(alphas will emit the offset warning: Hunk #1 succeeded at 55 (offset 10 lines).)

CommentFileSizeAuthor
2009-11-09_presave(Unix).patch2.16 KBarhak
2009-11-09_presave(Win).patch2.21 KBarhak

Comments

sinasalek’s picture

sinasalek commented

I sent you an email regarding to this issue, let me know if received it.

arhak’s picture

arhak commented

@#1 I just checked it
the (win) patch works for me on every versions: alpha1, beta1 & dev
patch -p0 < "../2009-11-09_presave(Win).patch" (being into the taxonomy_single_tag dir)

I can't review if the conversion to Unix is correct, since I get 

patch -p0 < "../2009-11-09_presave(Unix).patch"
Assertion failed: hunk, file patch.c, line 321
This application has requested the Runtime to terminate it in an unusual way.
Please contact the application's support team for more information.

But I'm used to get that error on Windows while the patch keeps working on Linux
just I have no real Linux around to test the conversion
If in doubt, use the Windows patch which only will raise extra warnings, but should work

Please, provide any error/warning messages this patch might be displaying

sinasalek’s picture

sinasalek commented

I copy & paste the patch from browser and i was using --binary switch in my shell script, that was the problem. i applied it now (Unix version and Windows version both work). named it beta2

arhak’s picture

arhak commented
Status: Needs review » Fixed

as usual, thanks sinasalek

now committed to beta2

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.