This module appears to be dead.

No notifications get sent, regardless of taxonomy, node, etc.
Group "fields" when added to the custom subscription come up empty in the drop list.

Anyone using this successfully?

--glen

Comments

danepowell’s picture

danepowell commented
Priority: Critical » Normal

Yes, I am using it quite successfully. Can you be more specific about what steps you take to reproduce this problem? Otherwise it's very difficult to help. It sounds like you might be describing two problems here, correct me if I'm wrong.

  1. I am seeing a bug where if you go to admin/messaging/customsubs/csid/xx/fields, select "Group" for field type and click "Add new field", then there are no groups to select in the "Value" box. I will investigate this.
  2. You are saying that no notifications are sent regardless of what fields are added- just to make sure that you understand, if you add multiple fields to a custom subscription (such as a content type and a taxonomy term), a notification will only be sent for nodes that have BOTH that type and term. In other words, fields are combined by 'AND', not 'OR'.
glen201’s picture

glen201 commented

Dane, thanks for responding.

1. You got that problem.
2. The bigger problem is that no notifications are sent. I understand the boolean issue, I am using single fields. For example, a taxonomy term. Or, a node type. I noticed in the database, looking in the notifications_fields table, that the record it inserted with the sid of entery in notifications table, the tid is +1 more than the tid of the taxonomy term I selected from the term_data table.

-- glen

danepowell’s picture

danepowell commented
Title: Custom Subscriptions DOA » Notifications not sending

Huh... well that's an interesting observation, and not something that I've seen before. I'll try to figure out why that might be happening.

I've split this into two issues, see #624908: No groups available for subscription

glen201’s picture

glen201 commented

Thanks for looking into it. Here's a clue:

I am also using the following in the notifications/OG module soup:

Notifications: 6.x-2.1
OG: 6.x-2.0
Organic groups vocabularies: 6.x-1.0
OG forum: 6.x-2.x-dev

Hope this helps.

-- glen

glen201’s picture

glen201 commented

Update to #2:

It's not that the tid is +1 of what it should be, it's that when the Fields are added to the notifications_custom, the **NEXT VALUE** in the list is added (the error is when the notification is being built). Upon examining the serialized fields column in notifications_custom, I see the next item in the term_data list indicated. In other words, looking in term_data table I see

tid vid name ....
24 6 General
28 1 Discussion group

If I select the field General when building the custom notification, it enters the tid for Discussion group -- the one that follows that field.

Got it?

So if I go in to notifications_custom and fix the serialized field, it creates the proper subscription tid for the users. HOWEVER, even with the right tid in the notifications_fields table, still no messages sent. Gonna try to figure out why next...
--glen

glen201’s picture

glen201 commented

Update to #5: Notifications seems to work when you fix the value in notifications_custom table.

However, still not sure why it's putting in the wrong tid. I've seen the inaccuracy sometimes when fields are selected from the autocomplete (the drop menu list) as you are typing, they get added with the wrong tid. When you type in the field, it seems to more accurately use the correct tid!

glen201’s picture

glen201 commented

Found a UI problem: in notifications_custom, the #description form type should reference $subs->description not explanation.

Also, all Field set titles on the Notifications overview page for the user are cap'd, so change "edit subscriptions" to "Edit subscriptions" (or, Subscribe to, which is preferrable).

Barberousse’s picture

Barberousse commented

Hello,

I have a similar problem: if I create a content type notification with notification UI on a content type called "nouvelle", it works: users receive notifications when a "nouvelle" content is created. But I want users to have the possibility to subscribe to this content type on the registration form. For that, I created a custom subscription called custom_subscription_list containing only one field content type -> nouvelle, the subscribing users don't receive notifications when I create a new "nouvelle" content.

It hapens with the stable and the devel version, with drupal mail and mime mail as mail sender engine.

Any progress on this bug?

Thank you.

Barberousse.

Barberousse’s picture

Barberousse commented

Hello,

My problem is different, I created a new thread here as suggested by Dane.

Barberousse

danepowell’s picture

danepowell commented

Okay folks, I'm going to try to tease apart the issues in this thread once again... it sounds like we have three:

1) the primary issue of notifications not sending, possibly caused by TIDs getting incremented for some reason (active)
2) the issue in 7, minor UI stuff (active)
3) Barberousse's problem of notifications not sending when subscribed on registration, which has been pinned down- the problem actually lies in existing subscriptions not being updated when a custom subscription is modified. (patch needed)

Please create separate issues for 2 and 3 and submit patches if possible. Let me know if I've missed something.

danepowell’s picture

danepowell commented
Status: Active » Postponed (maintainer needs more info)

I'd really like to help, but I'm still not able to reproduce this bug, which makes it exceedingly difficult to squash :) Unless you can give me more information on how to reproduce it there's not a whole lot I can do. I'd suggest sprinkling some echo statements in various parts of the code to try to determine exactly where the tid is getting corrupted. It's quite possible that it has nothing to do with custom subscriptions, or has been fixed in a new release.

jose reyero’s picture

jose reyero commented
Status: Postponed (maintainer needs more info) » Closed (fixed)

No follow up, so closing.