-- What are the steps required to reproduce the bug?
1) Create module with form
2) set, for example
$form['#attributes']['accept-charset'] = 'Windows-1251'
3) Form will have two "accept-charset" (with UTF-8 and with custom value)

-- What behavior were you expecting?
One accept-charset with custom value.

Patch sets UTF-8 as default accept-charset and we can override it from modules. I need this to send form to payment service and it accepts only Windows Cyrillic encoding. Patch was made from D6.14

CommentFileSizeAuthor
#9 accept_charset-624086-d6-9.patch910 bytesalbert volkman
#5 accept-charset.patch1.09 KBlimikael
#2 accept-charset.patch1.09 KBlimikael
accept-charset.patch918 bytesdmitriy.trt

Comments

lyricnz’s picture

lyricnz commented
Status: Needs review » Needs work

Patch should be made from drupal root directory - see http://drupal.org/patch/create

The "if" clause should use braces around the conditional clause:

You are strongly encouraged to always use curly braces even in situations where they are technically optional. Having them increases readability and decreases the likelihood of logic errors being introduced when new lines are added.

http://drupal.org/coding-standards

Does the same issue exist in D7? If so, it should be fixed there first, and back-ported. If not, the patch should probably be updated for 6.x-dev.

limikael’s picture

limikael commented
Status: Needs work » Needs review
StatusFileSize
new accept-charset.patch1.09 KB

Since I would really like to see this issue fixed I created a new patch with curly braces and from the root directory.

The patch was made from CVS on Apr 8, 2010.

Please have a look.

Status: Needs review » Needs work

The last submitted patch, accept-charset.patch, failed testing.

limikael’s picture

limikael commented
Version: 6.14 » 7.x-dev

This issue is still present in D7, changing version.

limikael’s picture

limikael commented
Status: Needs work » Needs review
StatusFileSize
new accept-charset.patch1.09 KB

Resubmitting patch for D7

casey’s picture

casey commented
Status: Needs review » Reviewed & tested by the community

Looks good.

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks.

moshe weitzman’s picture

moshe weitzman commented
Version: 7.x-dev » 6.x-dev
Status: Fixed » Patch (to be ported)
albert volkman’s picture

albert volkman commented
Status: Patch (to be ported) » Needs review
StatusFileSize
new accept_charset-624086-d6-9.patch910 bytes

D6 backport.

Status: Needs review » Closed (outdated)

Automatically closed because Drupal 6 is no longer supported. If the issue verifiably applies to later versions, please reopen with details and update the version.