For performance, themes can put all the Javascript files in the footer. this causes hardcoded script tags stuff to break. So this envasive patch removes all the cruft for the player for JS, adds a new file for drupal_kaltura helper that implements with behaviors.

similar to this: #623416: Don't use jQuery(document.ready())

Don't put script tags in your html, its will break a bunch of configurations.

CommentFileSizeAuthor
#2 kaltura_624544.patch1.59 KBScott Reynolds
#1 kaltura-player.patch9.56 KBScott Reynolds

Comments

Scott Reynolds’s picture

Scott Reynolds commented
StatusFileSize
new kaltura-player.patch9.56 KB

forgot to add the patch..

Scott Reynolds’s picture

Scott Reynolds commented
StatusFileSize
new kaltura_624544.patch1.59 KB

followup

Scott Reynolds’s picture

Scott Reynolds commented

+ $('div.kaltura-player:not(.kaltura-player-processed').each (function (i) {
is missing a closing ) on the 'not'.

joergvk’s picture

joergvk commented

Thanks a lot, Scott. I wonder why they didn't include the patch in the module by now. It's two months since you posted. On our site kaltura wouldn't work without the patch, because we load our javascript as late as possible for performance reasons. Like lots of other sites do.

joergvk’s picture

joergvk commented

Scott, your patches are no longer working. The code of the module was changed since you posted (without integrating your patches).

Scott Reynolds’s picture

Scott Reynolds commented
Status: Needs review » Needs work

Same info applies here, these two patches need to be rerolled into one patch. Also this patch doesn't address remix nodes, only kaltura_entry nodes.

univate’s picture

univate commented

I have taken some of the work here and integrated something similar into my version of this module:
http://github.com/univate/drupal-kaltura

The commit related to this issue is here:
http://github.com/univate/drupal-kaltura/commit/85a0c44ecc57828df8f1190e...