Request for co-maintiner status

Yay Kevin! Although I can't give CVS access, I can vouch for you no problem. I'll see if I can get one of the Drupal.org administrators to add you to the CVS access list.

We normally like to battle issues through the patch queue, but the list of people who actually contribute code and patches to the Drupal ShareThis module is very small.

In the mean time, if you upload some patches, I'd be more then willing to commit them :-) .

BTW denied both requests for transferring project ownership to newtman as Rob is an active co-maintainer. Anyone can submit patches and Rob said he's more than willing to review/commit them.

See:
#623534: Orphaned Module Ownership Change Request
#646388: Request for maintainer/co-maintainer status for ShareThis module
#623530: newtman [newtman]

Hi Kevin. I've run into this a number of times when adding new functionality or fixing bugs in existing modules. Submitting patches or code to the issue queue doesn't take anything away from the maintainer of the module. On the contrary, it's helping them out, and is how the development of all Drupal.org projects, including Drupal itself, work.

Reviewing patches and code and committing the good submitted code is what my job is. That's what my employer pays me to do and is what I do during my free time too. Whether I'm good at maintaining the modules I maintain is another question though :-P . But, if you submit a patch, or even a full blown module in a zip file or something, then I'd absolutely love to take a look and commit it. Drupal.org projects just go through the patch process so that everyone knows what code goes into the sites that they run, and they can fix/modify the code before it is deployed onto their website. If you get involved in the issue queue, and I see that the patches and code are reasonable and everyone seems to like and trust what you submit, then the CVS access will be yours :-) .

Again, please don't take offence to this. It's just how Drupal development works. The patch review process is a core reason why Drupal is as stable and secure as it is. Thanks a lot, Kevin, and I'll see you in the issue queue! :-)

Hi Kevin,

I've just begun using this module for two of the sites I maintain, and I would very much appreciate your contributions and bug fixes. It would be a terrific boon to this module to have one a genuine ShareThis developer working on it! Rob has welcomed your fixes and contributions here.

I've looked over the threads regarding your request for co-maintainer status, and noticed some perplexity on your part. That's not uncommon when people are getting started contributing to Drupal, since every OS project has its own culture and way of doing things. If you take the time to look at the issue queues for any active module, you'll see that it's very common for people to submit patches, which are evaluated and discussed in public, and often get committed to the module's official code by one of the maintainers.

I've submitted several patches to modules which have been incorporated, and I don't even have a CVS account yet, despite being a d.o. member for over 4 years! If I make concentrated improvements to a specific module, and become trusted by that module's maintainer and its users, then it's likely I could become a co-maintainer in CVS at that point. It's certainly not necessary to be a co-maintainer or have CVS access to make important fixes/improvements to a module.

I hope you'll persevere beyond these initial bumps and help ShareThis have terrific integration with Drupal. If there's anything I can do to help out, please let me know.

Anon gets the prize with the uploaded patch. Please see #619964: Javascript errors on IE, FF, Safari as his fix was committed. Upgrade to ShareThis 6.x-1.7 and then open up any additional issues if you have problems. Kevin, if you upload some patches and get involved in the issue queue, then we would be more then happy grant you CVS write access. Thanks a lot!