_apachesolr_nodeaccess_build_subquery() is apparently now just apachesolr_nodeaccess_build_subquery()

CommentFileSizeAuthor
apachesolr_views-solr2x-nodeaccess.patch682 bytestauno

Comments

Scott Reynolds’s picture

Scott Reynolds commented
Status: Needs review » Needs work

ya but its not that in apachesolr-6.x-1.x-dev

Need to either decide only apachesolr 6--2 or we need to add if(apachesolr 6--1) else do for apachesolr 6--2

toemaz’s picture

toemaz commented

subscribe

drewish’s picture

drewish commented
Status: Needs work » Needs review

Since the project page says this module requires ApacheSolr 2.x I think we can move on this.

drewish’s picture

drewish commented

I would have marked this as RTBC because it seems like an obvious fix but I'm not able to get it working. Not sure if there's another fix (#518500: Port over a patch to prevent apachesolr_nodeaccess from adding its subquery perhaps?) that needs to go into the mix.

tauno’s picture

tauno commented

The project that I'm using this for is now fairly far out of sync with this module. It's on my list to try to sync them up again so I'll try to revisit this then.

Scott Reynolds’s picture

Scott Reynolds commented

The problem with this is dealing with 1.x and 2.x compatibility with Apache Solr. 2.x removed underscores.

drewish’s picture

drewish commented

Scott, what do you mean maintaining compatibly? The project page say "Apache Solr Search Integration Project 6--2 and 7--3" so there should be no backwards compatibility issues... that or the project page needs to be changed to reflect compatibility with the 6--1 branch.

toemaz’s picture

toemaz commented

I follow drewish on this. Seems like there is no backwards compatibility required anymore.

franz’s picture

franz
any
Location Montréal
commented
Status: Needs review » Reviewed & tested by the community

This fix works for me pretty well.

dstuart’s picture

dstuart commented

Ok, Makes sense, ill commit now

dstuart’s picture

dstuart commented
Status: Reviewed & tested by the community » Fixed

Commit to trunk

dstuart’s picture

dstuart commented
Assigned: Unassigned » dstuart
Status: Fixed » Closed (fixed)

try that again